Bug 66232 - Outdated Doc about ${__time} function.
Summary: Outdated Doc about ${__time} function.
Status: NEW
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 5.5
Hardware: All All
: P2 normal (vote)
Target Milestone: JMETER_5.5
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-22 03:22 UTC by wangzhen
Modified: 2022-08-22 06:04 UTC (History)
0 users


Attachments
The code comparison between versions about the __time function. (186.53 KB, image/png)
2022-08-22 03:22 UTC, wangzhen 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description wangzhen 2022-08-22 03:22:52 UTC 
Created attachment 38371 [details]
The code comparison between versions about the __time function.

The latest document about ${__time()} function (https://jmeter.apache.org/usermanual/functions.html#__time) said that "The format to be passed to SimpleDateFormat. ", but as we can see in the code of version 5.5, it's using DateTimeFormatter now (https://docs.oracle.com/javase/8/docs/api/java/time/format/DateTimeFormatter.html).

As a result, in version before 5.5 we can use ${__time(u)} to get "day of week" in number. But in version 5.5, we should use ${__time(e)} instead.

The document should be updated to let user know the right time format.
Comment 1 Vladimir Sitnikov 2022-08-22 05:11:23 UTC 
Should we rollback the change for backwardcompatibility then?
Comment 2 wangzhen 2022-08-22 06:04:29 UTC 
(In reply to Vladimir Sitnikov from comment #1)
> Should we rollback the change for backwardcompatibility then?

I think it depends on the reason of this change. If it aims at solving some other issues, the document should be updated.

If not, a rollback would be great.
Comment 3 The ASF infrastructure team 2022-09-24 20:38:23 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/5694