Bug 66503 - [PATCH] Fix for XL4 Macros
Summary: [PATCH] Fix for XL4 Macros
Status: NEW
Alias: None
Product: POI
Classification: Unclassified
Component: XSSF (show other bugs)
Version: unspecified
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: POI Developers List
Keywords: PatchAvailable
Depends on:
Reported: 2023-03-01 22:26 UTC by M. P. Halpin
Modified: 2023-03-11 08:04 UTC (History)
0 users

Patch 3 files and add one new file. (4.15 KB, application/zip)
2023-03-01 22:26 UTC, M. P. Halpin

Note You need to log in before you can comment on or make changes to this bug.
Description M. P. Halpin 2023-03-01 22:26:57 UTC
Created attachment 38515 [details]
Patch 3 files and add one new file.

POI could not handle a couple Excel documents that have the (very old) legacy XL4 macros.  (These predated VBA.)

This change merely fixes that and marks their presence.
Comment 1 PJ Fanning 2023-03-01 22:43:47 UTC
The since value on the annotations say 3.14 - is this a mistake? 3.14 was released aeons ago. We will not patch 3.14 for you. 5.2.3 is the next release.

I would really prefer these patches to be Github PRs. svn patches are 2000 era cutting edge.
Comment 2 M. P. Halpin 2023-03-01 22:54:33 UTC
This patch was generated against 5.2.3;  isn't the next release 5.2.4?

I'm happy to create a GitHub PR, however this was submitted following the contribution guidelines on the POI website:


Should a PR be issued against https://github.com/apache/poi ?
Comment 3 PJ Fanning 2023-03-01 23:13:15 UTC
Why are you using since values of 3.14 then?

Some POI maintainers like svn. I hate it and I am the most active committer. Use svn if you like but I will bow out.
Comment 4 M. P. Halpin 2023-03-02 00:02:48 UTC
I ran into this using an older version of POI and then ran into it again with the latest release.

I will resubmit to Git, with a newer version number.

Apologies for any misunderstandings.
Comment 5 M. P. Halpin 2023-03-02 04:29:46 UTC
Filed Git pull request.