Bug 67767 - Bump max picture size in .HSLFSlideShowImpl.readPictures
Summary: Bump max picture size in .HSLFSlideShowImpl.readPictures
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: HSLF (show other bugs)
Version: unspecified
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-16 10:22 UTC by Tim Allison
Modified: 2023-10-16 10:43 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Allison 2023-10-16 10:22:29 UTC 
In prepping for our next release on Tika, we found ~1800 new exceptions caused by the added byte array (max picture length) check in HSLFSlideShowImpl.readPictures.

I support the added check, but we should bump the value higher.

I can't explain why this didn't turn up in earlier regression tests except that I must not have used the correct jars during the eval. :(

The largest value in our regression corpus is 95,000,000 bytes.  The limit is currently set at 10,000,000.
Comment 1 Tim Allison 2023-10-16 10:43:16 UTC 
r1913004