This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | XML Syntax migration to new Lexer | ||
---|---|---|---|
Product: | xml | Reporter: | Andrei Badea <abadea> |
Component: | Text-Edit | Assignee: | Svata Dedic <sdedic> |
Status: | NEW --- | ||
Severity: | blocker | CC: | marfous, samaresh |
Priority: | P3 | Keywords: | PLAN |
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | TASK | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 129020, 129027 |
Description
Andrei Badea
2008-03-04 16:22:52 UTC
I do not think I can get to this for 6.1. Samaresh : Are you planning to get it done for the 6.5 release? 'Coz one of issues in Spring # 129027 depends on it. The underlying parser for this is not lexer and the (old) editor syntax APIs. I'll look into it and get back. To me, this and issue 129027 are nice-to-have fixes. Samaresh : Did you get a chance to look into this issue? Are you still planning to take it up for 6.5 release? Regards, Sujit I'll look into it and get back. Hi Samaresh, Did you get time to look into this issue? Can you please let me know your plans to solve this? I wanted to reprioritize the dependent IZ#129027 accordingly. Thanks, Sujit I agree it is an issue but it should be addressed with Lexer migration. The problem is that, this piece of code uses editor's syntax API which is old. All of this (at some point) should be migrated to Lexer but I'm not sure when. This is really the core to XML parsing and potentially impacts a lot of code that depend on it. The lack of unit tests in this area makes it even more difficult to fix. 6.5 being around the corner, I suggest you re-prioritize and push for these changes in 7.0. Still valid issue in trunk (of nb71), changing the target milestone to Next (due to comment #7 which indicate much of work for fixing that), but please feel free and update the target milestone if you know when it could be probably really fixed. Thanks a lot. Issue is still valid in trunk (of nb73). This is because XML Syntax uses the old Lexer API/impl, which is semi-deprecated now. See the syntax highlighting, it already correctly reports attribute+value for the rest of the tag, and an error tag instead of whitespace. Highlighting is already based on new Lexer. I don't want to rewrite the SyntaxSupport into 7.3 release. Planning for the next release. (In reply to comment #10) > I don't want to rewrite the SyntaxSupport into 7.3 release. Planning for the > next release. Thanks, that's definitely good news. |