This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 149318

Summary: I18N : hardcoded strings at downloading V3
Product: serverplugins Reporter: Masaki Katakai <masaki>
Component: GlassFishAssignee: pslechta <pslechta>
Status: RESOLVED FIXED    
Severity: blocker CC: jf4jbug, pcw
Priority: P3 Keywords: I18N
Version: 6.x   
Hardware: All   
OS: All   
Issue Type: DEFECT Exception Reporter:

Description Masaki Katakai 2008-10-07 07:09:56 UTC
several messages at installing V3 on wizard are hardcoded. Please extract these messages to Bundle.properties.

glassfish.common/src/org/netbeans/modules/glassfish/common/wizards/Retriever.java:

    private static final String [] STATUS_MESSAGE = {
        "Ready.",
        "Connecting...",
        "Downloading...",
        "", // "Complete",
        "{0}: {1}",
        "", // "Terminated.",
        "Response from this URL is not a valid WSDL file.",
    };

  In getDurationString(),

            builder.append("an eternity");
            builder.append("no time at all");
                builder.append(hours > 1 ? " hours" : " hour");
                    builder.append(", ");
                builder.append(minutes > 1 ? " minutes" : " minute");
                    builder.append(seconds > 1 ? " seconds" : " second");
                builder.append(" ms");
Comment 1 _ pcw 2008-10-09 23:30:27 UTC
I hadn't decided how to localize the time messages, so these missed the cutoff for 6.5.
Comment 2 pslechta 2008-10-20 13:51:11 UTC
Confirmed. Will fix it.
Comment 3 pslechta 2008-10-21 13:03:51 UTC
Fixed.

http://hg.netbeans.org/main/rev/56c478083a13
Comment 4 _ pcw 2008-10-21 17:58:21 UTC
Thanks.  There is still a remaining issue in that mechanism used to construct display strings for the timing information
may produce word ordering that is incorrect for some locales.
Comment 5 Quality Engineering 2008-10-22 05:05:53 UTC
Integrated into 'main-golden', will be available in build *200810220201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/56c478083a13
User: pslechta@netbeans.org
Log: #149318 I18N : hardcoded strings at downloading V3