This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | org.netbeans.modules.php.dbgp.annotations.BrkpntAnnotation.getAnnotationType() is too expensive (LowPerformance took 20808 ms). | ||
---|---|---|---|
Product: | php | Reporter: | Exceptions Reporter <exceptions_reporter> |
Component: | Debugger | Assignee: | Ondrej Brejla <obrejla> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | PERFORMANCE |
Priority: | P3 | ||
Version: | 7.1 | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | 175997 |
Attachments: | nps snapshot |
Description
Exceptions Reporter
2012-06-13 13:41:26 UTC
Created attachment 120786 [details]
nps snapshot
The method org.netbeans.modules.php.dbgp.annotations.BrkpntAnnotation.getAnnotationType() is very expensive and is called 700x when doing undo in the editor. It takes over 70% of the overall time of the long undo operation. Please consider not doing the validity computation in getAnnotationType. Other implementations just return the type that is stored in some field ... Not so simple. A lot of things will have to be rewritten, because Breakpoint validity has to be checked somewhere. Wrong duplicate moved to issue #232704 Fixed in web-main #c2690c968844 and #d64cdbba416c Real-time "type" checking had to be disabled due to performance reasons (if one comments a line, where a valid BP is, it doesn't change its type to "broken" automatically. It will be still displayed as "valid" but will not work. Same behavior is in Java editor.). Integrated into 'main-silver', will be available in build *201307152300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/c2690c968844 User: Ondrej Brejla <obrejla@netbeans.org> Log: #214136 - org.netbeans.modules.php.dbgp.annotations.BrkpntAnnotation.getAnnotationType() is too expensive (LowPerformance took 20808 ms). |