This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 217956

Summary: UI Element / User-extensions are not configurable via Selenium Server Configuartion
Product: utilities Reporter: zarry
Component: SeleniumAssignee: Martin Fousek <marfous>
Status: CLOSED FIXED    
Severity: normal CC: mmirilovic
Priority: P3 Keywords: PATCH_AVAILABLE
Version: 6.x   
Hardware: PC   
OS: Windows XP   
Issue Type: ENHANCEMENT Exception Reporter:
Attachments: Enhancement to add User Extensions

Description zarry 2012-09-06 14:09:45 UTC
UI Element / User-extensions are not configurable via Selenium Server Configuration.

I have the need for custom UI elements with my instance of selenium server which is not configurable through the properties for selenium server plugin.
Comment 1 zarry 2012-09-11 22:08:36 UTC
Working on my own enhancement to this plugin, will submit a patch when it is ready.
Comment 2 Martin Fousek 2012-09-12 08:20:14 UTC
(In reply to comment #1)
> Working on my own enhancement to this plugin, will submit a patch when it is
> ready.

Hi, that would be great. Sorry, I have much more plugin to take care about so I have no time for improvements here right now. Patch would be really welcomed!
Comment 3 zarry 2012-09-18 12:54:21 UTC
Created attachment 124510 [details]
Enhancement to add User Extensions

Added the ability to set User Extensions on selenium server plugin.

Selenium server was starting using the start() command.  This was preventing user extensions from being called/loaded at run time.  I have adjusted the start() command to now call boot().  

This provides all the same behavior and allows user extensions to be loaded as part of the selenium server plugin.
Comment 4 Martin Fousek 2012-10-31 14:42:40 UTC
(In reply to comment #3)
> Created attachment 124510 [details]
> Enhancement to add User Extensions
> 
> Added the ability to set User Extensions on selenium server plugin.
> 
> Selenium server was starting using the start() command.  This was preventing
> user extensions from being called/loaded at run time.  I have adjusted the
> start() command to now call boot().  
> 
> This provides all the same behavior and allows user extensions to be loaded as
> part of the selenium server plugin.

Sorry for the delay I didn't get notification by email about your last comment here. I'm going to review and include the patch during this week and I will try to transplant it to 72 sources and rebuild and reupload the plugin to the Plugin Portal asap too. Thanks a lot for your contribution!
Comment 5 Martin Fousek 2012-11-01 08:58:33 UTC
Larry, thank you again for your contribution!

- I did small change in the patch (to call boot and start together, selenium docs are really bad and don't speak about it, but this looked to me more used solution)

- I wanted to commit and push that by your name but there is a HG hook which prevents me from doing that so I had to push that under my username:
http://hg.netbeans.org/main/contrib/rev/663af7e9300d

Now, I'll transplant the patch to the release72 branch and rebuild the plugin for the Plugin Portal. You should be noticed thru Autoupdate that new Selenium Server module exists.
Comment 6 Martin Fousek 2012-11-01 09:01:45 UTC
BTW, transplanted in http://hg.netbeans.org/main/contrib/rev/7ceebbb201a7.
Comment 7 zarry 2012-11-01 15:06:03 UTC
Awesome Martin, Thanks!

I had read a bit about boot() vs start() and I noticed some examples using both as well, I did not notice any difference between using just boot or boot vs start but as you said documentation was lacking.

The hook is probably in place from when I pulled down the repo.  I appreciate you getting it into a patch.

Thanks!