This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Patch for: Export the current keymap as HTML and show in browser | ||
---|---|---|---|
Product: | editor | Reporter: | markiewb |
Component: | Key bindings | Assignee: | Svata Dedic <sdedic> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | psomol, tomzi |
Priority: | P3 | Keywords: | PATCH_AVAILABLE |
Version: | 7.3 | ||
Hardware: | PC | ||
OS: | Windows 7 | ||
Issue Type: | ENHANCEMENT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 231968 | ||
Attachments: |
Proposed patch
Patch in action Updated screenshot Updated patch Updated screenshot II |
Description
markiewb
2013-03-03 23:28:26 UTC
Even jglick proposes to have a print button in the keymap panel - see https://blogs.oracle.com/geertjan/entry/hidden_netbeans_feature_export_shortcuts#comment-1327962019210 Created attachment 132121 [details]
Proposed patch
I like to propose the following patch to solve this issue.
The patch extends the existing ExportShortcutsAction to export a single keymap. There will a new "Print..." button in the keymap options panel, which will invoke the action using the current keymap profile. After the generation the file will be opened in the HTML-Browser via HtmlBrowser.URLDisplayer.getDefault().showURLExternal(). The shortcuts will be displayed as system-specific (like SHIFT-ALT instead if D-O). That is what the user expects because the keymap options panels also shows them system-specific.
Backwards-compatibility is preserved as much as possible. The original action works like before - it still shows platform-independent shortcuts for all profiles at the same time, but it will be opened in the HTML browser too.
@NB-Devs: Please review, discuss and commit.
Created attachment 132122 [details]
Patch in action
*** Bug 206360 has been marked as a duplicate of this bug. *** @Svata: Any change to get the patch integrated in 7.4? Do you need support/modifications from my side? After advice from our UI expert (in cc:), I made a minor rearrangement/rename of the buttons. See the attached screenshot. Additional changes/suggestions: * better error handling in exportShortcutsToHTML * shared code between ProfilesPanel and the export action Please review the suggested changes & the screenshot - thanks. Created attachment 134078 [details]
Updated screenshot
Created attachment 134079 [details]
Updated patch
Created attachment 134093 [details] Updated screenshot II (In reply to comment #6) > After advice from our UI expert (in cc:), I made a minor rearrangement/rename > of the buttons. See the attached screenshot. > > Additional changes/suggestions: > * better error handling in exportShortcutsToHTML > * shared code between ProfilesPanel and the export action > > Please review the suggested changes & the screenshot - thanks. @Svata: Your attached screenshot doesn't show the correct dialog. I applied the patch to my local sources. Looks good and works! Thanks. I added an updated screenshot. It can be used for the noteworthy page?! The HTML output isn't beautiful (not your fault/topic), but it is better than nothing and its improvement would be another RFE. Applied in rev http://hg.netbeans.org/jet-main/rev/a85b58d3330c Integrated into 'main-golden', will be available in build *201305052300* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-golden/rev/a85b58d3330c User: Svata Dedic <sdedic@netbeans.org> Log: #226955: Added HTML browser view of keymap [Benno Markiewicz] |