This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | handle CloneableOpenSupportRedirector based redirections | ||
---|---|---|---|
Product: | platform | Reporter: | Vladimir Voskresensky <vv159170> |
Component: | Text | Assignee: | Vladimir Voskresensky <vv159170> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | apireviews, issues |
Priority: | P2 | Keywords: | 8.0_HR_FIX, API_REVIEW_FAST |
Version: | 7.4 | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | 230126 | ||
Bug Blocks: | 241692, 242357 | ||
Attachments: |
proposed patch
patch with test proposed changes |
Description
Vladimir Voskresensky
2014-02-17 09:17:05 UTC
Created attachment 145290 [details]
proposed patch
Created attachment 145311 [details]
patch with test
updated implementation to pass functionality of CESRedirector based logic
Please, review. I'd like to integrate before clone btw, may be it's better to have in implementation of open(): this.beforeRedirect(redirected); redirected.open(); this.afterRedirect(redirected); ? Y01 Versioning, dependencies, javadoc, @since, apichanges, etc. is missing Y02 redirectedOpen Javadoc could have a sentence what starts with capital letter and does not use three letter abbrevations Y03 The diff does not show that, but I expect CloneableEditorSupportRedirectorTest.java is not modified, but copied to new file, which is then modified. OK. (In reply to Jaroslav Tulach from comment #5) > Y01 Versioning, dependencies, javadoc, @since, apichanges, etc. is missing Sure, will add > > Y02 redirectedOpen Javadoc could have a sentence what starts with capital > letter and does not use three letter abbrevations Ok > > Y03 The diff does not show that, but I expect > CloneableEditorSupportRedirectorTest.java is not modified, but copied to new > file, which is then modified. OK. I think diff shows "hg copy" or I miss something: copy from openide.text/test/unit/src/org/openide/text/CloneableEditorSupportRedirectorTest.java copy to openide.text/test/unit/src/org/openide/text/CloneableEditorSupportCOSRedirectorTest.java --- a/openide.text/test/unit/src/org/openide/text/CloneableEditorSupportRedirectorTest.java +++ b/openide.text/test/unit/src/org/openide/text/CloneableEditorSupportCOSRedirectorTest.java Created attachment 145411 [details]
proposed changes
updated patch based on comments and one more test method
please, review. I'm going to integrate tomorrow into trunk and release80 branch. Thanks integrated into trunk: http://hg.netbeans.org/cnd-main/rev/e018e41bc949 (to be transplanted into 8.0 as well) http://hg.netbeans.org/cnd-main/rev/e091ed5f3bc1 (versions) Integrated into 'main-silver', will be available in build *201402210001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/e091ed5f3bc1 User: Vladimir Voskresensky <vv159170@netbeans.org> Log: fixed #241991 - handle CloneableOpenSupportRedirector based redirections - update versions when transplant into release80 we need to update versions of: openide.options/manifest.mf xml/manifest.mf openide.loaders/manifest.mf xml.multiview/nbproject/project.properties properties/manifest.mf openide.text/manifest.mf openide.windows/manifest.mf verified in NetBeans IDE Dev (Build cnd-main-501-on-20140221) build transplanted: http://hg.netbeans.org/releases/rev/e5f3a068d90f versions: http://hg.netbeans.org/releases/rev/ff63bd84048d Integrated into 'main-silver', will be available in build *201402220001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main-silver/rev/8767c58a90bf User: Vladimir Voskresensky <vv159170@netbeans.org> Log: update versions after inc in trunk and transplant into 80 fix of #241991 - handle CloneableOpenSupportRedirector based redirections Integrated into 'releases/release80', will be available in build *201402242200* or newer. Wait for official and publicly available build. Changeset: http://hg.netbeans.org/releases/rev/e5f3a068d90f User: Vladimir Voskresensky <vv159170@netbeans.org> Log: fixed #241991 - handle CloneableOpenSupportRedirector based redirections - added afterRedirect - map fields after redirected COS/CES (transplanted from e018e41bc94955c017fc096f25e6e3576d7ed178) |