This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | I18N - Some parts of XML mount catalog window do not fully appear in other locales when translated and/or using larger font sizes | ||
---|---|---|---|
Product: | xml | Reporter: | Ken Frank <kfrank> |
Component: | Code | Assignee: | issues@xml <issues> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | Keywords: | I18N |
Priority: | P2 | ||
Version: | 3.x | ||
Hardware: | Sun | ||
OS: | Solaris | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 33246 | ||
Attachments: |
gif #1
gif #2 The patch Put this patch over previous one Proposed release35 branch patch |
Description
Ken Frank
2003-05-27 21:06:57 UTC
Created attachment 10469 [details]
gif #1
Created attachment 10470 [details]
gif #2
CatalogMounterPanel excerpt: setPreferredSize(new java.awt.Dimension(380, 100)); setMinimumSize(new java.awt.Dimension(380, 100)); The constant in setPreferredSize() is plain wrong. Also from CatalogRootNode: //^ packing never creates bigger window :-( myDialog.setSize(constantDimension); need to be calculated dynamically putting contrains on panel providers. Fixed in prj40_prototype branch, works well both with -fontsize 8 and -fontsize 22. Created attachment 10485 [details]
The patch
Created attachment 10489 [details]
Put this patch over previous one
The second patch contains changes that were "hidden" by form module. Created attachment 10699 [details]
Proposed release35 branch patch
Reviewed. Backported to release35 branch Checking in src/org/netbeans/modules/xml/catalog/CatalogMounterPanel.form; /cvs/xml/catalog/src/org/netbeans/modules/xml/catalog/CatalogMounterPanel.form,v <-- CatalogMounterPanel.form new revision: 1.4.2.1; previous revision: 1.4 done Checking in src/org/netbeans/modules/xml/catalog/CatalogMounterPanel.java; /cvs/xml/catalog/src/org/netbeans/modules/xml/catalog/CatalogMounterPanel.java,v <-- CatalogMounterPanel.java new revision: 1.5.2.1; previous revision: 1.5 done Checking in src/org/netbeans/modules/xml/catalog/CatalogRootNode.java; /cvs/xml/catalog/src/org/netbeans/modules/xml/catalog/CatalogRootNode.java,v <-- CatalogRootNode.java new revision: 1.15.2.1; previous revision: 1.15 done Processing log script arguments... More commits to come... Checking in src/org/netbeans/modules/xml/catalog/impl/SystemCatalogCustomizer.form; /cvs/xml/catalog/src/org/netbeans/modules/xml/catalog/impl/SystemCatalogCustomizer.form,v <-- SystemCatalogCustomizer.form new revision: 1.5.2.1; previous revision: 1.5 done Checking in src/org/netbeans/modules/xml/catalog/impl/SystemCatalogCustomizer.java; /cvs/xml/catalog/src/org/netbeans/modules/xml/catalog/impl/SystemCatalogCustomizer.java,v <-- SystemCatalogCustomizer.java new revision: 1.5.2.1; previous revision: 1.5 done Checking in src/org/netbeans/modules/xml/catalog/impl/XCatalogCustomizer.form; /cvs/xml/catalog/src/org/netbeans/modules/xml/catalog/impl/XCatalogCustomizer.form,v <-- XCatalogCustomizer.form new revision: 1.5.2.1; previous revision: 1.5 done Checking in src/org/netbeans/modules/xml/catalog/impl/XCatalogCustomizer.java; /cvs/xml/catalog/src/org/netbeans/modules/xml/catalog/impl/XCatalogCustomizer.java,v <-- XCatalogCustomizer.java new revision: 1.6.2.1; previous revision: 1.6 done Processing log script arguments... More commits to come... Checking in src/org/netbeans/modules/xml/catalog/impl/sun/CatalogCustomizer.form; /cvs/xml/catalog/src/org/netbeans/modules/xml/catalog/impl/sun/CatalogCustomizer.form,v <-- CatalogCustomizer.form new revision: 1.6.2.1; previous revision: 1.6 done Checking in src/org/netbeans/modules/xml/catalog/impl/sun/CatalogCustomizer.java; /cvs/xml/catalog/src/org/netbeans/modules/xml/catalog/impl/sun/CatalogCustomizer.java,v <-- CatalogCustomizer.java new revision: 1.7.2.1; previous revision: 1.7 done Can't verify yet, since some members of my team saw that after fix, some windows still did not show all but that the screen was at its maximum width but cannot be resized once there. Thus should issue be reopened or more global issue filed asking that window wrap to another line or provide scrollbar or other solution in these cases ? ken.frank@sun.com What screen resolution do they use? I'm affraid that layout managers approach works only for screens resolutions bigger than some minimum. Wrapping all panels into scrollbars? I think that's bad idea. Resultion UI could be slow and clumsy. I would set requirement to minimal screen resolution. Users can always use virtual desktops if their display does not handle the required minimum resolution. It the particular case the dialog requires space for textfield that is width enough to show 40 characters, its label and some spacing. In total it should be less than 80 characters. I do not how many Chinesse/Japanesse characters are commonly displayable in single row. You can try to shorten the label text if neccessary. as to shortening of label text, if this refers to what l10n would do, dont think that is a viable option - window should do the right thing no matter what the text - ja an zh translations about same lg as english but other languages can expand lg by 50-80%. That is, l10n should not need to customize a translation. And this is also general issue of user running at other fontsize, so its not just string length but fontsize as well. ken.frank@sun.com Could you please attach the screenshot. I probably cannot image what the problem is. IMHO it's fixed, Ken. What do you think? I've tested it on current dev (4.0) build with -fontsize 18 on resolution 1200x1600 and dialogs related to XML catalogue are fine. If you still some problems, please reopen it and describe exactly where it is and attache apropriate screenshot too. |