This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Property sheet very slow | ||
---|---|---|---|
Product: | platform | Reporter: | Tomas Pavek <tpavek> |
Component: | Explorer | Assignee: | _ tboudreau <tboudreau> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | Keywords: | PERFORMANCE |
Priority: | P2 | ||
Version: | 3.x | ||
Hardware: | PC | ||
OS: | Windows ME/2000 | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 36949 |
Description
Tomas Pavek
2004-01-15 17:58:20 UTC
Has the performance changed recently, or was it always like this? I recently fixed an issue that PropertySheet should not display properties if Property.isHidden() is true. It does mean an extra iteration of the properties, where before I could just throw whatever the Node gave me into a model. If it has changed, try running with -J-Dnetbeans.ps.showHiddenProperties=true That will help me to figure out if it's that change that caused the problem or something else. The code that handles setting up the tabs could probably be optimized a bit as well. Since it looks like I'm going to steal your nice new UI classes for the Component Palette tabs (thanks!), I can probably do some optimizing while I'm doing that. Also could you try running with -J-Dnetbeans.ps.nevertabs=true and see if the performance problem is still there when tabs are not used? According to my observation -J-Dnetbeans.ps.showHiddenProperties=true has no effect (also form editor does not produce any hidden properties. OTOH using -J-Dnetbeans.ps.nevertabs=true brings noticeable improvement. More, I have a feeling that the property sheet (with tabs) slows down continuously when working like it was dependent somehow on number of nodes I visit (or something like that). I'll try to give you some responsiveness numbers if interested. Interesting. Yeah, if you have numbers (or better, profiling data showing where it's spending its time), that would be quite cool. Don't go to too much trouble, though. If it's slowing down as you go, that's interesting. FYI, I paid special attention to how the replacement for the tabbed pane would perform - hopefully the fix for issue 38703 will fix this as well - it will be a complete replacement of the code that handles this. I haven't tuned the look yet (since I developed it on the mac and things look different here), but you might want to try out the replacement for the tabbed pane and see if this solves the problem. The performance seems fine to me, but maybe you were doing something different than I am. If you want, there is a 1 file branch (silly, I know): cvs co -r ps_new_tabs $NB_SRC/openide/src/org/openide/explorer/propertysheet/ SheetTabbedPane.java I'll give it a try. When it is available in trunk anyway? BTW I've just tested current build with UI measuring turned on and really seen the painting performance going down gradually with the number of visited nodes (e.g. switching to GUI window group changed from like 400ms to 2500ms). Marking this as fixed - the code that was involved has been completely rewritten, and I can detect no performance problems with the new SheetTabbedPane. Ok, looks much better now. Verified. |