This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | [2004-04-22] Multiview and (Cloneable)EditorSupport | ||
---|---|---|---|
Product: | platform | Reporter: | Jaroslav Tulach <jtulach> |
Component: | Window System | Assignee: | Milos Kleint <mkleint> |
Status: | CLOSED FIXED | ||
Severity: | blocker | CC: | mkleint, tpavek |
Priority: | P1 | ||
Version: | 4.x | ||
Hardware: | PC | ||
OS: | Linux | ||
Issue Type: | TASK | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 19871, 41085 | ||
Attachments: | Introducing CES.Pane to allow other TopComponents to implement it and delegate to CloneableEditor |
Description
Jaroslav Tulach
2004-03-24 17:11:09 UTC
I could not find any current tests focusing on EditorSupport/CloneableEditorSupport behaviour. How can I then define compatibility then? can the current CloneableEditorSupportTest be of any help? CloneableEditorSupportTest defines basic behaviour and should give you an idea how to write tests. You can use it as inspiration, but you cannot just plug into it. Moreover it does not focus on getEditorPanes() functionality at all. However the interaction between multiview and the support will be unique anyway, reuse of the old tests is hard to imagine. Weel, I was more interested in the used contract between API user and the API. And the test interation is simplified compared to real-life example. Also clearly shows what is actually supported. Created attachment 14259 [details]
Introducing CES.Pane to allow other TopComponents to implement it and delegate to CloneableEditor
reassigning http://openide.netbeans.org/source/browse/openide/src/org/openide/text/?only_with_tag=multiview_march2004 files in openide.text that changed. NnDocument, CloneableEditorSupport and CloneableEditor changed APIs. EditorSupport rewritten, changes verified by implementing basic MultiView impl for form module. Test not written yet. test written. I'd like to suggest some changes: 1. when doing assert in other thread then the original one that executed the test, the failure is never reported (aka invokeLater+assert) 2. override method runInEQ() and you do not need to mangle with AWT anymore. CloneableOpenSupport seems to do Mutex.EVENT.writeAccess which is synchronous when run from AWT thread 3. suggestion for test. Make sure that: Line line = support.getLineSet().getCurrent(0); line.show(Line.SHOW_SHOW); calls to yourTopComponent.requestActivated() done Fine. |