Bug 47947

BTW a bug in the way form module uses AntArtifact:

File outputFile = new File(
    artifacts[i].getScriptLocation().getParent()
    + File.separator
    + artifacts[i].getArtifactLocation().getPath());

is not correct. artifactLocation may be an absolute URI. Anyway
constructing a File with '/' separators on Windows is also wrong. You
need to do (with some added error checking):

new
File(aa.getScriptLocation().toURI().resolve(aa.getArtifactLocation()).normalize())

If Add to Pallette... is disabled then it would become lost
functionality from 3.6.  If too much more lost functionality occurs
people are going to bail on 4.0.


From my perspective the product feature is seriously affected, so it
should stay P2.

You misunderstand this bug report - this is about politely handling
the case that a project does not supply a particular feature, not
about adding the feature to the project.

Again, you can use Tools -> Palette Manager to set up whatever you
like. The "Add to Palette" shortcut is available on some project
types, such as standard Java projects. Currently not on freeform
projects, since it would require an addition to the freeform
project.xml syntax as well as some logic in the freeform properties
dialog to update it, which we did not have time to do for 4.0 before
feature freeze.

If the official line will be "not supported in freeform for 4.0" then
it sohuld be consistant.  

From the Palette Manager "add from project" lists no available beans
from a selected freeform project, my supposition being that it is the
same reason Add to Palette... fails.  That may be a P4/P5 type bug
since it makes the wizard unprogressable rather than throwing up
exception dialogs or silently failing but I feel the user shouldn't be
lead on to beleieve that by some rain dance they could make it work if
only they shook it the right way.  

I would recommend either (1) disableing the next button when a
freeform project is seeclted on the first page, possibly with a red
highlight text right above the button bar line "Components cannot be
automatically imported from a FreeForm Project" or (2) a "stopper"
page after the select page explaining that components cannot be
imported from a freeform project and recommending that the user
instead import from a built jar.  A select component page that is
entirely empty but otherwise functional implies to me that I could do
something to the selected project so that later I could make the beans
show up.  In fact a "no beans found" stopper page may be better wether
or not it is a freeform project.

I am uncertian wether to open another bug for this or keep it under
this bug with a broader umbrella for "properly handle" no AAQ

Use Add from JAR, not Add from Project, in the case of a freeform
project in 4.0. But yes, the import bean wizard should detect such
border cases early and deal with them better.

Fixed - both the Add to Palette action and Palette Manager
handle this situation more politely.

Well, it's hard to verify now since freeform now updates thw export 
element, and it seems to work for adding components to the swing 
pallette (as of dev build 200409291800).

Well it's nice to hear it's hard to verify for that reason. :-) Should
be possible to verify by making a test freeform project and deleting
the <export> elements in project.xml.

verified