This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 57201

Summary:	Keyboard shortcuts cleanup
Product:	editor	Reporter:	Roman Strobl <rstrobl>
Component:	Options	Assignee:	Jan Jancura <jjancura>
Status:	CLOSED FIXED
Severity:	blocker
Priority:	P3
Version:	4.x
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Bug Depends on:
Bug Blocks:	58412

Description Roman Strobl 2005-03-30 14:33:24 UTC

Let's clean up keyboard shortcuts for release after 4.1, there are some obsolete
or unused actions. Here's the list:

- annotations cycling - not very useful action
- beep - :-)
- bookmarks-kit-install - needs to be hidden
- dump view hierarchy - hard to understand
- expand abbreviation - cannot be redefined from default space
- hide code completion - not neccessary, we have escape
- insert content - not needed
- select next parameter - quite obscure
- set read only - not usable
- set write only - not usable

As we've discussed the Alt-U U or similar shortcuts are difficult for using, we
should make it so that users keep holding the Alt key for the second key, too.

It would be great to divide the shortcuts into basic (those who users will most
likely want to override) and advanced. Currently we have a lot of actions and
it's quite hard to find the right one in the list. This would make keyboard
shortuct settings much friendlier.

Can you also consider if anyone needs settings of keys like left, right, up,
down, tab and similar keys? It's fine if we keep it as it is but my goal is to
remove everything that is not necessary to make the configuration easier for
users. So if we find out that nobody needs these settings there's no reason to
keep them there.

Comment 1 Roman Strobl 2005-03-30 14:50:03 UTC

I have also gone through java keybindings and the following two actions are strange:

- debug filename and line number
- debug identifier

Comment 2 Martin Roskanin 2005-03-30 15:10:35 UTC

bookmarks-kit-install already hidden.

As for other changes, setting TM to PromoF

/cvs/editor/bookmarks/src/org/netbeans/lib/editor/bookmarks/actions/BookmarksKitInstallAction.java,v
 <--  BookmarksKitInstallAction.java
new revision: 1.2; previous revision: 1.1

Comment 3 Jan Jancura 2005-04-28 19:24:28 UTC

Thanks for this issue, Roumen! We definitelly need to fix current set of actions
/ shortcuts for the new Options Dialog. Currently I have 470 actions there! It
makes Options Dialog - Keymaps unusable.

Comment 4 Martin Roskanin 2005-10-21 14:24:15 UTC

Hanz, to fix the problem at your side simply use the filter similarly as in code
of KeyBindingsEditorPanel:
Object internalActionObj = actions[i].getValue(BaseAction.NO_KEYBINDING);
                if (internalActionObj instanceof Boolean){
                    if (((Boolean)internalActionObj).booleanValue()){
                        continue; //filter out editor internal actions - #49589
                    }
                }

By this, you will get rid of the actions like Build Popup Menu, Build Tool Tip,
etc.. as mentioned at issue #49589

For actions mentioned here in this issue the value NO_KEYBINDING needs to be
added yet

Comment 5 Martin Roskanin 2005-10-21 15:01:33 UTC

fixed in [maintrunk] as for editor:
/cvs/editor/libsrc/org/netbeans/editor/ActionFactory.java,v  <--  ActionFactory.java
new revision: 1.69; previous revision: 1.68

/cvs/editor/libsrc/org/netbeans/editor/BaseKit.java,v  <--  BaseKit.java
new revision: 1.140; previous revision: 1.139

/cvs/editor/libsrc/org/netbeans/editor/ext/ExtKit.java,v  <--  ExtKit.java
new revision: 1.62; previous revision: 1.61

/cvs/java/editor/src/org/netbeans/modules/editor/java/JavaKit.java,v  <-- 
JavaKit.java
new revision: 1.22; previous revision: 1.21

Comment 6 Jan Jancura 2005-11-16 15:59:44 UTC

fixed in trunk:

IDE:-------------------------------------------------
IDE: [16.11.05 16:59] Committing "EditorBridge.java" started
Checking in EditorBridge.java;
/cvs/editor/options/src/org/netbeans/modules/options/keymap/EditorBridge.java,v
 <--  EditorBridge.java
new revision: 1.2; previous revision: 1.1
done
IDE: [16.11.05 16:59] Committing "EditorBridge.java" finished

Comment 7 Roman Strobl 2005-11-21 13:14:13 UTC

Verified.