This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 57753

Summary:	New javadoc build property prevents standalone builds
Product:	java	Reporter:	_ tball <tball>
Component:	Project	Assignee:	Petr Hrebejk <phrebejk>
Status:	RESOLVED FIXED
Severity:	blocker	Keywords:	SIMPLEFIX
Priority:	P2
Version:	4.x
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Bug Depends on:
Bug Blocks:	50039, 57820
Attachments:	Simple patch Patch for ejbjar module Patch for web module

Description _ tball 2005-04-11 22:44:35 UTC

The javadoc.additionalparam property has been added to J2SE projects, but unlike
the other javadoc properties its value is defined in
nbproject/private/private.properties instead of nbproject/project.properties. 
This breaks command-line builds on other systems, since private.properties is
supposed to be system-specific and therefore should not be committed to a shared
repository.  Please move its definition to project.properties, which is shareable.

Comment 1 Jesse Glick 2005-04-11 23:04:49 UTC

Right, was there some reason for this, or just an oversight?

Comment 2 Petr Hrebejk 2005-04-12 14:34:08 UTC

I think this was fixed already.

<from J2SEProjectProperties.java>
        JAVADOC_ADDITIONALPARAM_MODEL = projectGroup.createStringDocument(
evaluator, JAVADOC_ADDITIONALPARAM );
<from J2SEProjectProperties.java>

which means that the property is stored in project.properties. Using an older
build? Older project? Different project type? If in web please reopmen and
assign to web/project.

Comment 3 Jesse Glick 2005-04-12 18:19:03 UTC

Using a 4.2 dev build, I have a j2seproject I made today, and I added "-hello"
to Javadoc options. In project.properties I get

javadoc.additionalparam=

and in private.properties I get

javadoc.additionalparam=-hello

so this is definitely not fixed.

J2SEProjectGenerator correctly puts the blank initial entry into
project.properties. But J2SEProjectProperties uses

JAVADOC_ADDITIONALPARAM_MODEL = privateGroup.createStringDocument( evaluator,
JAVADOC_ADDITIONALPARAM );

I'm not sure what version of sources you're looking into here, but clearly
"privateGroup" should be "projectGroup".

Note: someone who was including an absolute filename into additional params
would really want to use private.properties - or, more likely, use
project.properties but refer to a separate custom property def in
private.properties. But I think this would be the rare case.

Comment 4 Petr Hrebejk 2005-04-13 10:07:06 UTC

Created attachment 21596 [details]
Simple patch

Comment 5 Petr Hrebejk 2005-04-13 10:10:49 UTC

I'm sorry. My fault (pretty stupid). I have it on my disk for several weeks but
I did not commit that into the code base. 

So I did now. Will try to put it into 4.1

Checking in
src/org/netbeans/modules/java/j2seproject/ui/customizer/J2SEProjectProperties.java;
/cvs/java/j2seproject/src/org/netbeans/modules/java/j2seproject/ui/customizer/J2SEProjectProperties.java,v
 <--  J2SEProjectProperties.java
new revision: 1.51; previous revision: 1.50
done

Comment 6 zikmund 2005-04-13 10:20:46 UTC

Reproducible in Web & EJB projects - see issue 57820.

Comment 7 Radko Najman 2005-04-13 12:31:08 UTC

Created attachment 21607 [details]
Patch for ejbjar module

Comment 8 Radko Najman 2005-04-13 12:31:58 UTC

Created attachment 21608 [details]
Patch for web module

Comment 9 Jesse Glick 2005-04-13 14:06:49 UTC

Consider this code-reviewed. :-)

Comment 10 Milan Kubec 2005-04-15 08:27:51 UTC

Fix verified in trunk build 200504141800. javadoc.additionalparam is generated
to project.properties file.

Comment 11 Petr Hrebejk 2005-04-15 09:45:43 UTC

Merged to 4.1

/cvs/java/j2seproject/src/org/netbeans/modules/java/j2seproject/ui/customizer/J2SEProjectProperties.java,v
 <--  J2SEProjectProperties.java
new revision: 1.50.2.1; previous revision: 1.50
done