This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 64410

Summary:	Suggest some cleanup in Java parsing support
Product:	java	Reporter:	_ rkubacki <rkubacki>
Component:	Unsupported	Assignee:	_ rkubacki <rkubacki>
Status:	RESOLVED FIXED
Severity:	blocker	CC:	tor
Priority:	P3
Version:	5.x
Hardware:	All
OS:	All
Issue Type:	TASK	Exception Reporter:
Attachments:	suggested patch

Description _ rkubacki 2005-09-15 09:53:50 UTC

After some fixes in editor I found that noone is listening to
java/src/org/netbeans/modules/java/Parsing.java that currently only refires
events from Java model. I guess we can cut this support to make this part simpler.

Comment 1 _ rkubacki 2005-09-15 09:56:05 UTC

Created attachment 24825 [details]
suggested patch

Comment 2 _ rkubacki 2005-09-15 10:00:06 UTC

I'd like to apply attached patch + remove following files
java/src/org/netbeans/modules/java/ErrConsumer.java
java/src/org/netbeans/modules/java/ParserMessage.java
java/src/org/netbeans/modules/java/Parsing.java
java/src/org/netbeans/modules/java/parser/ParserMessageImpl.java

qa-functional tests have the same pass/fail ratio as before the change.

The only usage of this listener I was able to found is in tasklist/javaparser.
Maybe Tor knows if this is really needed or whether it could be converted to a
different listener (attached to Java model directly).

Comment 3 Tomas Hurka 2005-09-15 14:06:31 UTC

The main problem is that this incompatible API change. It should be consulted with Jarda, if we can do 
it.

Comment 4 _ rkubacki 2005-09-20 10:31:42 UTC

Although Jarda does not have any strong objection it might be OK to deprecate
the classes that we are going to remove and delete them at the begining of next
release cycle.

Comment 5 _ rkubacki 2005-09-29 13:43:42 UTC

I marked them as deprecated and will remove them once the 5.0 is branched. If I
understand correctly to our policy it is possible to do such a change for an API
that is not official.

Checking in java/src/org/netbeans/modules/java/ErrConsumer.java;
/cvs/java/src/org/netbeans/modules/java/ErrConsumer.java,v  <--  ErrConsumer.java
new revision: 1.11; previous revision: 1.10
done
Checking in java/src/org/netbeans/modules/java/ParserMessage.java;
/cvs/java/src/org/netbeans/modules/java/ParserMessage.java,v  <-- 
ParserMessage.java
new revision: 1.4; previous revision: 1.3
done
Checking in java/src/org/netbeans/modules/java/Parsing.java;
/cvs/java/src/org/netbeans/modules/java/Parsing.java,v  <--  Parsing.java
new revision: 1.13; previous revision: 1.12

Comment 6 _ rkubacki 2005-12-17 16:10:03 UTC

Removing java/src/org/netbeans/modules/java/ErrConsumer.java;
/shared/data/ccvs/repository/java/src/org/netbeans/modules/java/ErrConsumer.java,v
 <--  ErrConsumer.java
new revision: delete; previous revision: 1.11
done
Checking in java/src/org/netbeans/modules/java/JavaDataLoader.java;
/shared/data/ccvs/repository/java/src/org/netbeans/modules/java/JavaDataLoader.java,v
 <--  JavaDataLoader.java
new revision: 1.77; previous revision: 1.76
done
Removing java/src/org/netbeans/modules/java/ParserMessage.java;
/shared/data/ccvs/repository/java/src/org/netbeans/modules/java/ParserMessage.java,v
 <--  ParserMessage.java
new revision: delete; previous revision: 1.4
done
Removing java/src/org/netbeans/modules/java/Parsing.java;
/shared/data/ccvs/repository/java/src/org/netbeans/modules/java/Parsing.java,v 
<--  Parsing.java
new revision: delete; previous revision: 1.13
done
Checking in java/src/org/netbeans/modules/java/parser/ParseObjectRequest.java;
/shared/data/ccvs/repository/java/src/org/netbeans/modules/java/parser/ParseObjectRequest.java,v
 <--  ParseObjectRequest.java
new revision: 1.9; previous revision: 1.8
done
Checking in java/src/org/netbeans/modules/java/parser/ParseSourceRequest.java;
/shared/data/ccvs/repository/java/src/org/netbeans/modules/java/parser/ParseSourceRequest.java,v
 <--  ParseSourceRequest.java
new revision: 1.24; previous revision: 1.23
done
Removing java/src/org/netbeans/modules/java/parser/ParserMessageImpl.java;
/shared/data/ccvs/repository/java/src/org/netbeans/modules/java/parser/ParserMessageImpl.java,v
 <--  ParserMessageImpl.java
new revision: delete; previous revision: 1.2
done
Checking in java/src/org/netbeans/modules/java/parser/ParsingSupport.java;
/shared/data/ccvs/repository/java/src/org/netbeans/modules/java/parser/ParsingSupport.java,v
 <--  ParsingSupport.java
new revision: 1.46; previous revision: 1.45
done