This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | [GTK] Selected Tab is hardly visible | ||
---|---|---|---|
Product: | platform | Reporter: | Martin Krauskopf <mkrauskopf> |
Component: | Window System | Assignee: | Martin Krauskopf <mkrauskopf> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | ramos |
Priority: | P4 | Keywords: | GTK |
Version: | 5.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: |
Tabs.png
Screenshot showing view tabs and editor tabs |
Description
Martin Krauskopf
2005-11-07 09:38:47 UTC
Created attachment 26670 [details]
Tabs.png
you want to look at the core/swing/tabcontrol module. BasicScrollingTabDisplayerUI class I guess, some L&Fs have custom subclasses, the gtk doesn't so far. reassigning as I don't have gtk on any of my computers.. Thanks to Milos and Dafe for their clues where should I look. Fixed. Checking in swing/tabcontrol/plaf/WinClassicEditorTabCellRenderer.java; 1.9 --> 1.10; Checking in swing/tabcontrol/plaf/WinClassicViewTabDisplayerUI.java; 1.21 --> 1.22; Marking this issue as VERIFIED since the issue reporter == issue owner. I am missing something here? The original screenshot looks great compared with the screenshot I have attached now. The pic reflects the hardcoded settings: GTK_TABBED_PANE_BACKGROUND_1 = new Color(100, 100, 100); GTK_TABBED_PANE_BACKGROUND_2 = new Color(255, 255, 255); in the files: WinClassicEditorTabCellRenderer.java WinClassicViewTabDisplayerUI.java That makes the text hardly readable. Created attachment 33734 [details]
Screenshot showing view tabs and editor tabs
I think the following settings would be acceptable for readability and selection visibility: GTK_TABBED_PANE_BACKGROUND_1 = new Color(255, 255, 255);//white GTK_TABBED_PANE_BACKGROUND_2 = UIManager.getColor("TabbedPane.background"); > I am missing something here? The original screenshot looks great compared
> with the screenshot I have attached now.
The problem is that you are comparing Editor's tabs with the explorer's tabs.
Editor's ones are wider so they look good with the current implementation ->
before it was very hard to find which one was selected.
But agree that explorer's ones are sometime hard to read. It just depends on
how wide a tab is. Wider -> better. I'll try your suggestions, thanks.
PS: better set TM to TBD since you can't know when it will be fixed ;) Can't be
for 5.5 anyway, since we cannot touch the core platform, only serious bug.
I've applied your suggestion. We will see if there is somebody who have yet another color-feeling ;) Thanks for the "patch". Applied. src/org/netbeans/swing/tabcontrol/plaf/WinClassicEditorTabCellRenderer.java; new revision: 1.14; previous revision: 1.13 src/org/netbeans/swing/tabcontrol/plaf/WinClassicViewTabDisplayerUI.java; new revision: 1.25; previous revision: 1.24 I downloaded an tested it. Thanks. I think it looks better now. I had read some user comments on the NBUI mailing list and also comments on my blog about the GTK LaF and this topic. I hope people will be happy with the results. |