This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Admin name and password in properties are changed after entering user /password in Authentication dialog | ||
---|---|---|---|
Product: | serverplugins | Reporter: | Roderico Cruz <rcruz> |
Component: | Sun Appserver 9 | Assignee: | _ ludo <ludo> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | pjiricka |
Priority: | P2 | ||
Version: | 5.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: |
Zip containing Secure Web App Project
patch |
Description
Roderico Cruz
2006-09-22 22:30:25 UTC
Created attachment 34399 [details]
Zip containing Secure Web App Project
global Adminauthenticator does not filter is the request if for admin APIs or any other http request...Mahybe we need to check for the port number? I'll look into that (admin requests are on 4848 where as secure user apps would not be on that port...) We need to call the getRequestingPort() API to check is it is the same as the admin port. If not, no need to store the u/p as it is not for the admin port. Easy fix I think. good catch. Fix almost ready. Created attachment 34464 [details]
patch
Please review the patch. The idea is to do an extra test for the requesting server to detect if this is the admin port or the user app port. On case of user port, we do not trigger the logic about updating the U/p for Admin apis. if the preferredSDMI is null, there is still a possibility that ip won't be null. if ip isn't null, then the InstanceProperties' username and password attributes might get changed.... Would it be a good idea to remove the else at lines 70-74 of 1.2.8.2.2.3.2.1? preferredSDMI cannot be null currently unless the constructor is given a null value, and our code is not passing null. But I agree with handling this case as well, as suggested. incr diff checked in in dev: --- AdminAuthenticator.java 25 Sep 2006 16:28:43 -0000 1.2.8.2.2.3.2.1 +++ AdminAuthenticator.java 25 Sep 2006 23:53:12 -0000 @@ -67,11 +67,12 @@ preferredSunDeploymentManagerInterface.getHost(), preferredSunDeploymentManagerInterface.getPort()); } - } else { - keyURI=SunURIManager.SUNSERVERSURI+site.getHostName()+":"+getRequestingPort(); - ip= InstanceProperties.getInstanceProperties(keyURI); - } +// else { +// keyURI=SunURIManager.SUNSERVERSURI+site.getHostName()+":"+getRequestingPort(); +// ip= InstanceProperties.getInstanceProperties(keyURI); +// +// } v. in release55_dev; please commit the fix also to release55 branch in release55 as well. cvs commit -m "Fix for http://www.netbeans.org/issues/show_bug.cgi?id=85605 in release55" -- AdminAuthenticator.java (in directory E:\nb_all\serverplugins\sun\appsrv\src\org\netbeans\modules\j2ee\sun\ide\editors\) Checking in AdminAuthenticator.java; /cvs/serverplugins/sun/appsrv/src/org/netbeans/modules/j2ee/sun/ide/editors/AdminAuthenticator.java,v <-- AdminAuthenticator.java new revision: 1.2.8.2.2.4; previous revision: 1.2.8.2.2.3 done verified in build 20060929000 |