This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 85806

Summary:	Make class abstract hint does not work
Product:	java	Reporter:	Petr Hrebejk <phrebejk>
Component:	Source	Assignee:	Jan Lahoda <jlahoda>
Status:	RESOLVED FIXED
Severity:	blocker	CC:	msauer
Priority:	P3
Version:	6.x
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Bug Depends on:
Bug Blocks:	87136
Attachments:	screenshot

Description Petr Hrebejk 2006-09-26 17:53:14 UTC

When having a non-abstract class with abstract methods, a hint should appear,
offering to make the class abstract. "Implement abstract methods" appears
instead, which does not make sense. See attached screenshot.

Using the improper hint makes the hint system unusable from than on -- Alt-Enter
or Clicking on bulbs stops working.

Steps to reproduce:
-----------------------------------
1) Create a java class
2) Make an abstract method inside
3) Invoke appeared hint and use it
--> Wrong hint type
4) Type a printline statement somewhere
--> "Hardcoded string" hint cannot be invoked, altough a bulb is displayed

-----
netbeans-retouche-200607100800.zip
JDK 1.5.0_07
Solaris 10/Sparc

Comment 1 Petr Hrebejk 2006-09-26 17:54:00 UTC

Created attachment 34529 [details]
screenshot

Comment 2 Jiri Prox 2006-10-04 10:44:45 UTC

It looks like it has been fixed

Comment 3 Jiri Prox 2006-10-04 10:46:28 UTC

Sorry marked as fixed by mistake

Comment 4 Jan Lahoda 2006-10-09 16:15:33 UTC

Should be fixed:
Checking in test/unit/src/org/netbeans/modules/java/hints/JavaHintsTest.java;
/cvs/java/hints/test/unit/src/org/netbeans/modules/java/hints/Attic/JavaHintsTest.java,v
 <--  JavaHintsTest.java
new revision: 1.1.2.5; previous revision: 1.1.2.4
done
RCS file:
/cvs/java/hints/test/unit/data/org/netbeans/test/java/hints/Attic/AbstractClass4.java,v
done
Checking in test/unit/data/org/netbeans/test/java/hints/AbstractClass4.java;
/cvs/java/hints/test/unit/data/org/netbeans/test/java/hints/Attic/AbstractClass4.java,v
 <--  AbstractClass4.java
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in
src/org/netbeans/modules/java/hints/ImplementAllAbstractMethodsCreator.java;
/cvs/java/hints/src/org/netbeans/modules/java/hints/Attic/ImplementAllAbstractMethodsCreator.java,v
 <--  ImplementAllAbstractMethodsCreator.java
new revision: 1.1.2.3; previous revision: 1.1.2.2
done
RCS file:
/cvs/java/hints/test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/Attic/testNonAbstractClass85806-hints.pass,v
done
Checking in
test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/testNonAbstractClass85806-hints.pass;
/cvs/java/hints/test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/Attic/testNonAbstractClass85806-hints.pass,v
 <--  testNonAbstractClass85806-hints.pass
new revision: 1.1.2.1; previous revision: 1.1
done

Comment 5 Max Sauer 2006-10-16 12:28:03 UTC

Make class abstract hint still does not work -- on the contrary, wrong hint type
is no longer offered.

Steps to reproduce:
-------------------
1) Create a new java class
2) Type an abstract method declaration, ie:
public abstract double Eval();
=> No 'Make class abstract' hint offered.

----
Product Version         = NetBeans IDE Dev (Build 061016)
Operating System        = Linux version 2.6.12-1.1390_FC4smp running on i386
Java; VM; Vendor; Home  = 1.5.0_05; Java HotSpot(TM) Server VM 1.5.0_05-b05; Sun
Microsystems Inc.; /usr/jdk1.5.0_05/jre
System Locale; Encoding = en_US (nb); UTF-8

Comment 6 Jan Lahoda 2006-10-16 13:26:34 UTC

Ok, I supposed this was mainly about the incorrect hint. The make class abstract
hint should be implemented now:
RCS file:
/cvs/java/hints/test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/Attic/testMakeClassAbstract3-hints.pass,v
done
Checking in
test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/testMakeClassAbstract3-hints.pass;
/cvs/java/hints/test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/Attic/testMakeClassAbstract3-hints.pass,v
 <--  testMakeClassAbstract3-hints.pass
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file:
/cvs/java/hints/test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/Attic/testMakeClassAbstract3.pass,v
done
Checking in
test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/testMakeClassAbstract3.pass;
/cvs/java/hints/test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/Attic/testMakeClassAbstract3.pass,v
 <--  testMakeClassAbstract3.pass
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file:
/cvs/java/hints/test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/Attic/testMakeClassAbstract1.pass,v
done
Checking in
test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/testMakeClassAbstract1.pass;
/cvs/java/hints/test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/Attic/testMakeClassAbstract1.pass,v
 <--  testMakeClassAbstract1.pass
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file:
/cvs/java/hints/test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/Attic/testMakeClassAbstract2.pass,v
done
Checking in
test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/testMakeClassAbstract2.pass;
/cvs/java/hints/test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/Attic/testMakeClassAbstract2.pass,v
 <--  testMakeClassAbstract2.pass
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file:
/cvs/java/hints/test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/Attic/testMakeClassAbstract2-hints.pass,v
done
Checking in
test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/testMakeClassAbstract2-hints.pass;
/cvs/java/hints/test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/Attic/testMakeClassAbstract2-hints.pass,v
 <--  testMakeClassAbstract2-hints.pass
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file:
/cvs/java/hints/test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/Attic/testMakeClassAbstract1-hints.pass,v
done
Checking in
test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/testMakeClassAbstract1-hints.pass;
/cvs/java/hints/test/unit/data/goldenfiles/org/netbeans/modules/java/hints/JavaHintsTest/Attic/testMakeClassAbstract1-hints.pass,v
 <--  testMakeClassAbstract1-hints.pass
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in test/unit/src/org/netbeans/modules/java/hints/JavaHintsTest.java;
/cvs/java/hints/test/unit/src/org/netbeans/modules/java/hints/Attic/JavaHintsTest.java,v
 <--  JavaHintsTest.java
new revision: 1.1.2.11; previous revision: 1.1.2.10
done
Checking in
src/org/netbeans/modules/java/hints/ImplementAllAbstractMethodsCreator.java;
/cvs/java/hints/src/org/netbeans/modules/java/hints/Attic/ImplementAllAbstractMethodsCreator.java,v
 <--  ImplementAllAbstractMethodsCreator.java
new revision: 1.1.2.4; previous revision: 1.1.2.3
done
RCS file:
/cvs/java/hints/test/unit/data/org/netbeans/test/java/hints/Attic/MakeClassAbstract1.java,v
done
Checking in test/unit/data/org/netbeans/test/java/hints/MakeClassAbstract1.java;
/cvs/java/hints/test/unit/data/org/netbeans/test/java/hints/Attic/MakeClassAbstract1.java,v
 <--  MakeClassAbstract1.java
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file:
/cvs/java/hints/test/unit/data/org/netbeans/test/java/hints/Attic/MakeClassAbstract3.java,v
done
Checking in test/unit/data/org/netbeans/test/java/hints/MakeClassAbstract3.java;
/cvs/java/hints/test/unit/data/org/netbeans/test/java/hints/Attic/MakeClassAbstract3.java,v
 <--  MakeClassAbstract3.java
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file:
/cvs/java/hints/test/unit/data/org/netbeans/test/java/hints/Attic/MakeClassAbstract2.java,v
done
Checking in test/unit/data/org/netbeans/test/java/hints/MakeClassAbstract2.java;
/cvs/java/hints/test/unit/data/org/netbeans/test/java/hints/Attic/MakeClassAbstract2.java,v
 <--  MakeClassAbstract2.java
new revision: 1.1.2.1; previous revision: 1.1
done