Issue 103148

Summary:

Avoid early crash in generic plugin

Product:

gsl

Reporter:

thb

Component:

code

Assignee:

philipp.lohmann

Status:

CLOSED FIXED

QA Contact:

issues@gsl <issues>

Severity:

Trivial

Priority:

CC:

issues, philipp.lohmann

Version:

current

Target Milestone:

OOo 3.2

Hardware:

All

OS:

Unix, all

Issue Type:

PATCH

Latest Confirmation in:

---

Developer Difficulty:

---

Attachments:

Description	Flags
the fix	none

Description thb 2009-06-26 18:19:02 UTC

Running OOo in Xnest/Xephyr w/o any window manager here crashes because of an
apparent race during startup (non-available ucb) - I was not able to reproduce
that in a normal SAL_USE_VCLPLUG=gen session (though did not try for hours);
following trivial patch fixes this, mimicking similar code in the gtk plug.

Comment 1 thb 2009-06-26 18:19:59 UTC

Created attachment 63238 [details]
the fix

Comment 2 thb 2009-06-26 18:22:00 UTC

@pl: would you be ok with this fix?

Comment 3 philipp.lohmann 2009-06-29 10:04:32 UTC

That actually is a go-oo problem only. Our intro bitmap has the
SAL_FRAME_STYLE_INTRO, but since you're the second one to blame go-oo's fault on
OOo, I'l commit it. It sure doesn't hurt to be on the safe side.

Comment 4 philipp.lohmann 2009-06-29 10:05:01 UTC

thanks for the patch

Comment 5 philipp.lohmann 2009-06-29 10:11:56 UTC

committed in CWS vcl103

Comment 6 thb 2009-06-30 12:55:45 UTC

@pl: thanks for taking it. :)

Comment 7 philipp.lohmann 2009-07-13 13:06:23 UTC

verified in CWS vcl103

Comment 8 philipp.lohmann 2009-07-28 14:15:10 UTC

integrated