Issue 103148 - Avoid early crash in generic plugin
Summary: Avoid early crash in generic plugin
Status: CLOSED FIXED
Alias: None
Product: gsl
Classification: Code
Component: code (show other issues)
Version: current
Hardware: All Unix, all
: P3 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: philipp.lohmann
QA Contact: issues@gsl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-26 18:19 UTC by thb
Modified: 2009-07-28 14:15 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
the fix (2.04 KB, patch)
2009-06-26 18:19 UTC, thb 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description thb 2009-06-26 18:19:02 UTC 
Running OOo in Xnest/Xephyr w/o any window manager here crashes because of an
apparent race during startup (non-available ucb) - I was not able to reproduce
that in a normal SAL_USE_VCLPLUG=gen session (though did not try for hours);
following trivial patch fixes this, mimicking similar code in the gtk plug.
Comment 1 thb 2009-06-26 18:19:59 UTC 
Created attachment 63238 [details]
the fix
Comment 2 thb 2009-06-26 18:22:00 UTC 
@pl: would you be ok with this fix?
Comment 3 philipp.lohmann 2009-06-29 10:04:32 UTC 
That actually is a go-oo problem only. Our intro bitmap has the
SAL_FRAME_STYLE_INTRO, but since you're the second one to blame go-oo's fault on
OOo, I'l commit it. It sure doesn't hurt to be on the safe side.
Comment 4 philipp.lohmann 2009-06-29 10:05:01 UTC 
thanks for the patch
Comment 5 philipp.lohmann 2009-06-29 10:11:56 UTC 
committed in CWS vcl103
Comment 6 thb 2009-06-30 12:55:45 UTC 
@pl: thanks for taking it. :)
Comment 7 philipp.lohmann 2009-07-13 13:06:23 UTC 
verified in CWS vcl103
Comment 8 philipp.lohmann 2009-07-28 14:15:10 UTC 
integrated