|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | sw: crash when pasting footnote into frame | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Writer | Reporter: | dtardon <dtardon> | ||||||
| Component: | code | Assignee: | michael.ruess | ||||||
| Status: | CLOSED FIXED | QA Contact: | issues@sw <issues> | ||||||
| Severity: | Trivial | ||||||||
| Priority: | P2 | CC: | issues, mst.ooo, orw | ||||||
| Version: | OOo 3.2 | Keywords: | regression | ||||||
| Target Milestone: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Issue Type: | PATCH | Latest Confirmation in: | --- | ||||||
| Developer Difficulty: | --- | ||||||||
| Attachments: |
|
||||||||
|
Description
dtardon
2010-04-30 13:20:15 UTC
Created attachment 69195 [details]
possible fix
it was OK in 3.1.1 od->dtardon: Thx, for finding the crash and the attached patch to solve it. Shall be solved for OOo 3.3 Deeper investigation reveals that the defect has been introduced by cws odfmetadata3. The attached patch fixes the crash. But, due to the made changes in cws odfmetadata3 further stuff is broken: In a version which has the attached patch applied to the following: - new text document - write text "AAA BBB CCC" - insert a footnote after "AAA" - make "BBB" bold - insert a text frame - copy the written text including the footnote and the bold "BBB" - paste it into the text frame --> no crash, but the first "B" in the pasted text is not bold. od->mst: Please take over as you have done the changes to method <SwTxtNode::CopyText(..)> in cws odfmetadata3. Before the changes of cws odfmetadata3 have been applied there already exists a check, if the copied text attribute has been inserted. If not and the text attribute has no ending index a special character is inserted into the copied text instead. This code has been also removed by cws odfmetadata3. Further note to the given incorrect behavior: The first "B" is not bold instead the following blank is bold. Thus, the text attributes following the not copied footnote are shifted. so to shift the following attributes one position back should be enough, right? Created attachment 69302 [details]
like this
od->dtardon: Yes, you are right. Let wait for mst - he is currently on vacation. apparently i was unaware that InsertHint could actually fail in this way... i assumed it could not fail for set of hints that already had been successfully inserted in another node. thanks for the patch dtardon! [actually i am surprised to find that InsertHint with SETATTR_NOTXTATRCHR will remove a dummy character that it hasn't inserted itself... but in this case i guess it's needed.] fixed in cws sw33bf04 http://hg.services.openoffice.org/hg/cws/sw33bf04/rev/2bdf873c4a7f while looking at the CopyText function i've also finally removed a block of code with one of the most ridiculous comments in the whole writer code... "best not to touch it before the BETA", indeed :) http://hg.services.openoffice.org/hg/cws/sw33bf04/rev/07cdc75d3922 please verify . Verified fix in CWS sw33bf04. *** Issue 112285 has been marked as a duplicate of this issue. *** *** Issue 112353 has been marked as a duplicate of this issue. *** closing, integrated m82 *** Issue 113351 has been marked as a duplicate of this issue. *** *** Issue 115059 has been marked as a duplicate of this issue. *** *** Issue 115059 has been marked as a duplicate of this issue. *** |