|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | [From Symphony]animation flash once doesn't work after save the ppt by aoo | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Impress | Reporter: | louqle <louqingle> | ||||||
| Component: | save-export | Assignee: | Andre <awf.aoo> | ||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||
| Severity: | Normal | ||||||||
| Priority: | P3 | CC: | awf.aoo, liushenf, phoenix.wanglf, tmyl2010 | ||||||
| Version: | 3.4.0 | ||||||||
| Target Milestone: | 4.0.0 | ||||||||
| Hardware: | PC | ||||||||
| OS: | All | ||||||||
| Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||||
| Developer Difficulty: | --- | ||||||||
| Attachments: |
|
||||||||
I am looking at this bug. Created attachment 78422 [details]
119740 & 119699 patch
When save to PPT. the fill properties for TRANSITIONFILTER and ANIMATE note should use default value, if they parent node is default value. @Tang Meng: Can you explain why the patch is necessary? There is already code in GetFillMode(...) that returns nFill when nFill==AnimationFill::DEFAULT. A general explanation of the root cause and the idea of the fix would be helpful also. *** Issue 119699 has been marked as a duplicate of this issue. *** When save to PPT. the fill properties for TRANSITIONFILTER and ANIMATE note should use default value. This is 'AnimationFill::DEFAULT'. In the old code when 'nFill == AnimationFill::DEFAULT', the nFill is set as 'nFillDefault'. But 'nFillDefault' isn't 'AnimationFill::DEFAULT' in some case. The result is that we don't return 'AnimationFill::DEFAULT'. So the patch is necessary. Thanks for the explanation. It would be nice to have that as comment in the patch instead of listing the bugs it fixes--after the patch is applied the bugs are gone and a description of old bugs is not so interesting. Reviewed. Committed with SVN revision 1353438. |
Created attachment 77948 [details] sample file 1. open the attached ppt file by aoo 2. save as another .ppt file 3. reopen the new .ppt file by aoo or powerpoint 2003, play the animation flash once doesn't work