Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | Implement GTK test into configure. | ||||||
---|---|---|---|---|---|---|---|
Product: | Build Tools | Reporter: | foskey | ||||
Component: | code | Assignee: | foskey | ||||
Status: | CLOSED FIXED | QA Contact: | issues@tools <issues> | ||||
Severity: | Trivial | ||||||
Priority: | P3 | CC: | issues, khirano, pavel | ||||
Version: | OOo 1.1 Beta2 | ||||||
Target Milestone: | OOo 1.1 RC | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Issue Type: | PATCH | Latest Confirmation in: | --- | ||||
Developer Difficulty: | --- | ||||||
Attachments: |
|
Description
foskey
2003-06-21 12:21:59 UTC
Created attachment 7029 [details]
gtk test...
approved. Committed patch in asis basis. Please forward to the gtk experts to determine correct version required. mh->hro: please review. Just a comment, the PKG_CHECK_MODULES means that I cannot produce a configure anymore because PKG_CHECK_MODULES is provided by pkg-config. I don't have GTK on windows. Perhaps you can mail me your aclocal.m4 Ken, if that is enough we should commit it to config_office. @Volker: Can you please do the appropreate changes so it works on all platforms (including Win32). This configure stuff is quite criptic to me so I guess I'm not the right person to review this. Hi Hennes! Technically the patch is OK now, Ken committed the needed aclocal to RC and now a plain autoconf in config_office creates the correct configure again. This could have also been done by using autoreconf, which creates the aclocal file. Now back to the question: Do we check for the correct gtk+ version. Volker The patch checks for gtk+2 module version 1.3.13 while we have tested with module version 2.2.2. It may work with older version. I feel Ken has a reason to recommend 1.3.13. If it works it's O.K. for me otherwise I would recommend 2.0.0 as minimum module version. @Ken: If GTK+ 2.0 version 1.3.13 works please apply the changes to configure script. Closing issue fixed. When someone fails a build with a bad version we can increase the requirements then. Closing |