Issue 15893 - Implement GTK test into configure.
Summary: Implement GTK test into configure.
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: OOo 1.1 Beta2
Hardware: PC All
: P3 Trivial (vote)
Target Milestone: OOo 1.1 RC
Assignee: foskey
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-21 12:21 UTC by foskey
Modified: 2003-07-31 02:32 UTC (History)
3 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
gtk test... (1.02 KB, patch)
2003-06-21 12:22 UTC, foskey 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description foskey 2003-06-21 12:21:59 UTC 
The attached patch will allow autoconf to test for the existance of the gtk
libraries.  Make sure you run aclocal;autoconf when you apply this patch.

This will enable us to test for the existance of these lirbaries.
Comment 1 foskey 2003-06-21 12:22:28 UTC 
Created attachment 7029 [details]
gtk test...
Comment 2 Martin Hollmichel 2003-06-23 11:22:17 UTC 
approved.
Comment 3 foskey 2003-06-28 00:50:37 UTC 
Committed patch in asis basis.

Please forward to the gtk experts to determine correct version required.
Comment 4 Martin Hollmichel 2003-06-28 16:34:02 UTC 
mh->hro: please review.
Comment 5 quetschke 2003-06-29 14:56:49 UTC 
Just a comment, the PKG_CHECK_MODULES means that I cannot produce
a configure anymore because PKG_CHECK_MODULES is provided by
pkg-config. I don't have GTK on windows.

Perhaps you can mail me your aclocal.m4 Ken, if that is enough
we should commit it to config_office.
Comment 6 hennes.rohling 2003-06-30 17:16:10 UTC 
@Volker: Can you please do the appropreate changes so it works on all
platforms (including Win32). This configure stuff is quite criptic to
me so I guess I'm not the right person to review this.
Comment 7 quetschke 2003-06-30 18:10:54 UTC 
Hi Hennes!

Technically the patch is OK now, Ken committed the needed aclocal to RC
and now a plain autoconf in config_office creates the correct
configure again. This could have also been done by using autoreconf,
which creates the aclocal file.

Now back to the question: Do we check for the correct gtk+ version.

  Volker
Comment 8 hennes.rohling 2003-07-01 13:43:46 UTC 
The patch checks for gtk+2 module version 1.3.13 while we have tested
with module version 2.2.2. It may work with older version. I feel Ken
has a reason to recommend 1.3.13. If it works it's O.K. for me
otherwise I would recommend 2.0.0 as minimum module version.
Comment 9 hennes.rohling 2003-07-03 10:32:43 UTC 
@Ken: If GTK+ 2.0 version 1.3.13 works please apply the changes to
configure script.
Comment 10 foskey 2003-07-18 11:46:50 UTC 
Closing issue fixed.

When someone fails a build with a bad version we can increase the
requirements then.
Comment 11 foskey 2003-07-31 02:32:01 UTC 
Closing