|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | WW8: Alignment in numbering label wrong in RTL | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Internationalization | Reporter: | sforbes <xslf> | ||||||||||||
| Component: | BiDi | Assignee: | michael.ruess | ||||||||||||
| Status: | CLOSED FIXED | QA Contact: | issues@l10n <issues> | ||||||||||||
| Severity: | Trivial | ||||||||||||||
| Priority: | P3 | CC: | alan, caolanm, elisko, hennerd, issues, yba | ||||||||||||
| Version: | 680m22 | ||||||||||||||
| Target Milestone: | --- | ||||||||||||||
| Hardware: | All | ||||||||||||||
| OS: | All | ||||||||||||||
| Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||||||||||
| Developer Difficulty: | --- | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
sforbes
2004-02-16 13:01:24 UTC
Created attachment 13186 [details]
the file
another example. Notice also that the single digit list items are incurrectly aligned, where the single digit is aligned under the 10ths digit in the dual digit items Created attachment 13195 [details]
exmpale 2
adding dina as cc DL->MRU: Could you please handle this? MRU->HB: the numbers are not right aligned in the labels after import. This property has to be set automatically by the import. changed summary. Looks like the numbering alignment attribute is not set correctly for RTL paragraphs during the import. Created attachment 17011 [details]
simple bugdoc
*** Issue 34632 has been marked as a duplicate of this issue. *** Changed prio to 4 *** Issue 37901 has been marked as a duplicate of this issue. *** I raise the priority again but I've to retarget this issue to OOo later. I'm not sure I understand all of the problems mentioned below. When I try to open the attached examples, I am asked to install Open Office.org, which is already installed! I do have a similar problem in Writer, without importing from Word or exporting to Word (or any other programme). When I choose right alignment for numbering, the alignment is correct, but there is no space between numbering and text. OOWriter offers the possibility to add space, but then the right alignment disappears! It would be nice if this could be fixed in the next version. I can confirm the bug still exists with oo.org 2.4.0 on Debian. Please update the bug version info and re-target it. Thanks. Created attachment 57696 [details]
proposed patch
I've submitted a patch to fix the alignment of numbering on MS doc import. Even though numbering alignment is set in the constructor of WW8ListManager, I can't set it there, since it is known only later, during pStyles->Import(), whether the document's direction is RTL. So I added another function to be called after pStyles->Import(), which resets the alignment of the numbering. Please review, and set the issue status to fixed if OK. Applied patch (DEV300_m32), but issue still present. ayaniger: Perhaps the default page properties play a role? When I load left_right_align.doc, IsRightToLeft() always returns false. Thus, ChangeAlignmentForRtl() is never called. Created attachment 57989 [details]
revised patch
ayaniger->hbrinkm: Yes you are correct. This revised patch checks the text direction of the text for each numbering group, and aligns the numbering accordingly. Sending source/filter/ww8/ww8par.hxx Sending source/filter/ww8/ww8par3.cxx Transmitting file data .. Committed revision 263722. ready for QA Verified in CWS hb12. Checked fix in DEV300m38. |