Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | configure should not require unicows.dll on dev300 code line | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Build Tools | Reporter: | Mathias_Bauer | ||||||
Component: | configure | Assignee: | Oliver-Rainer Wittmann <orw> | ||||||
Status: | CLOSED FIXED | QA Contact: | issues@tools <issues> | ||||||
Severity: | Trivial | ||||||||
Priority: | P3 | CC: | carsten.driesner, hennes.rohling, issues, Mathias_Bauer, orw, stephan.bergmann.secondary | ||||||
Version: | DEV300m10 | ||||||||
Target Milestone: | 3.4.1 | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Issue Type: | DEFECT | Latest Confirmation in: | --- | ||||||
Developer Difficulty: | --- | ||||||||
Attachments: |
|
Description
Mathias_Bauer
2008-04-23 15:45:13 UTC
target 3.0 Created attachment 65472 [details]
presumably this is as trivial as this....
I'll take over According to OpenGrok there are some more places that refer to unicows: postprocess/signing/no_signing.txt postprocess/rebase/no_rebase.txt solenv/inc/set_wntx64.mk solenv/inc/set_wntgcci.mk solenv/inc/set_wntmsci10.mk solenv/inc/set_wntmsci11.mk ure/source/README All are trivial fixes sal/systools/win32/uwinapi/makefile.mk sal/systools/win32/uwinapi/unicowsdxp sal/systools/win32/uwinapi/unicows_mingw.dxp I'm unsure about that; this is just a list of exported symbols. Perhaps someone of the experts can comment on that. sal/systools/win32/uwinapi/DllMain.cpp The code to load unicows.dll should be removed also sal/osl/w32/process.cxx vcl/win/source/window/salframe.cxxMentions some workarounds for bugs in unicows.dll; they should be removed then vcl/win/source/app/salinfo.cxx code for WINVER<0x5000 -> remove taking over in order to apply Caolan's patch and to clean up the rest of the code regarding unicows.dll taking over this issue Created attachment 76838 [details]
patch to remove Window Build requirement of unicows.dll - it includes cmc's patch
I have attached a patch which includes cmc's patch and cleans up the references to unicows.dll given by mba. Beside sal/systools/win32/uwinapi/DllMain.cpp the patch also removes sal/systools/win32/uwinapi/DllGetVersion.cpp |