Issue 88652

Summary: configure should not require unicows.dll on dev300 code line
Product: Build Tools Reporter: Mathias_Bauer
Component: configureAssignee: Oliver-Rainer Wittmann <orw>
Status: CLOSED FIXED QA Contact: issues@tools <issues>
Severity: Trivial    
Priority: P3 CC: carsten.driesner, hennes.rohling, issues, Mathias_Bauer, orw, stephan.bergmann.secondary
Version: DEV300m10   
Target Milestone: 3.4.1   
Hardware: All   
OS: All   
Issue Type: DEFECT Latest Confirmation in: ---
Developer Difficulty: ---
Description Flags
presumably this is as trivial as this....
patch to remove Window Build requirement of unicows.dll - it includes cmc's patch none

Description Mathias_Bauer 2008-04-23 15:45:13 UTC
unicows.dll is not needed anymore because we dropped win9x support
Comment 1 Mathias_Bauer 2008-04-23 15:45:41 UTC
target 3.0
Comment 2 caolanm 2009-10-20 11:44:15 UTC
Created attachment 65472 [details]
presumably this is as trivial as this....
Comment 3 Mathias_Bauer 2009-11-11 14:32:48 UTC
I'll take over
Comment 4 Mathias_Bauer 2010-05-12 17:19:55 UTC
According to OpenGrok there are some more places that refer to unicows:

All are trivial fixes

I'm unsure about that; this is just a list of exported symbols. Perhaps someone
of the experts can comment on that.

The code to load unicows.dll should be removed also

vcl/win/source/window/salframe.cxxMentions some workarounds for bugs in
unicows.dll; they should be removed then

code for WINVER<0x5000 -> remove

Comment 5 Oliver-Rainer Wittmann 2011-09-22 09:35:57 UTC
taking over in order to apply Caolan's patch and to clean up the rest of the code regarding unicows.dll
Comment 6 Oliver-Rainer Wittmann 2011-09-27 14:30:19 UTC
taking over this issue
Comment 7 Oliver-Rainer Wittmann 2011-09-27 14:33:24 UTC
Created attachment 76838 [details]
patch to remove Window Build requirement of unicows.dll - it includes cmc's patch
Comment 8 Oliver-Rainer Wittmann 2011-09-27 14:35:59 UTC
I have attached a patch which includes cmc's patch and cleans up the references to unicows.dll given by mba.

Beside sal/systools/win32/uwinapi/DllMain.cpp the patch also removes sal/systools/win32/uwinapi/DllGetVersion.cpp