|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | Hebrew parentheses during presentation - wrong direction | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Impress | Reporter: | tzuktz <tzuktz> | ||||||||||
| Component: | viewing | Assignee: | groucho266 | ||||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||||
| Severity: | Normal | ||||||||||||
| Priority: | P3 | CC: | alan, hdu, hennerd, issues, kaplanlior, roberttucker, thb | ||||||||||
| Version: | OOO300m9 | ||||||||||||
| Target Milestone: | 4.0.0 | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Issue Type: | PATCH | Latest Confirmation in: | 3.4.1 | ||||||||||
| Developer Difficulty: | --- | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
tzuktz
2009-02-19 12:25:56 UTC
Please attach a document for testing. Thanks. Created attachment 60317 [details]
bugdoc
Attached bugdoc. The mirroring of the parentheses seems to be fixed in OOO310_m1. However, there is another problem. Will attach screenshot. The parentheses are misplaced, probably because the text string is handled in LTR order instead of RTL. If you set the text direction to LTR, you will get the same placement in edit mode. Created attachment 60318 [details]
Screenshot OOO310_m1i
In ooo310m1 the doc looks ok for me in edit mode and in presentation mode. After setting the text to LTR I can see the problem of your screenshot. I have attached some screenhots: is this the problem you see? Created attachment 60319 [details]
screenshots
I get the same "directly after opening" result. However, when I go to presentation mode, I get the LTR result, even if the text was set to RTL in edit mode. Checked this on Vista Sp1. Will check the document again on XP later on, could be Vista specific, if you failed to reproduce on XP. @wg: I can reproduce the effect also on Win XP. Under Tools, Options, View: Hardware acceleration is turned on. If I turn it off, the display is correct also in presentation mode. Created attachment 64910 [details]
patch to add bidi support to DirextX canvas
In dx_textlayout.cxx, settings for text direction were simply ignored. I copied the corresponding code from vcl based textlayout.cxx to dx_textlayout.cxx and dx_textlayout_drawhelper.cxx, and this seems to fix the problem. +1 There was some discussion of this problem in the comments to issue 95259. ping ? Any news about the patch ? I'm adding this comment to all open issues with Issue Type == PATCH. We have 220 such issues, many of them quite old. I apologize for that. We need your help in prioritizing which patches should be integrated into our next release, Apache OpenOffice 4.0. If you have submitted a patch and think it is applicable for AOO 4.0, please respond with a comment to let us know. On the other hand, if the patch is no longer relevant, please let us know that as well. If you have any general questions or want to discuss this further, please send a note to our dev mailing list: dev@openoffice.apache.org Thanks! -Rob The problem still persists in current version 3.4.1 I don't see any relevant changes made to the source files on trunk recently, so I assume that the patch is still applicable. Unfortunately I don't have a build environment set up at the moment to verify. See similar bug at LibreOffice at https://bugs.freedesktop.org/show_bug.cgi?id=60533 and its fix at http://cgit.freedesktop.org/libreoffice/core/commit/?id=6708ad7f1baa8d4cef1718bdef1d26fb5d8510f3 "hdu" committed SVN revision 1455505 into trunk: #i99414# add bidi support to the DirextX canvas Applied for AOO4.0. Henner: Thanks for the patch! Good to hear from you! Lior and Alan: Thanks for the links! *** Issue 110270 has been marked as a duplicate of this issue. *** Closing resolved issue. |