SA Bugzilla – Bug 1527
new MIME decoder
Last modified: 2004-03-06 08:46:40 UTC
Write a new MIME decoder and integrate it with the existing MIME and MIME attachment tests in EvalTests.pm. My reasoning: I think it makes sense for us to have our own decoder (like HTML) because we'll be able to integrate the parsing/decoding with tests (like HTML), to avoid extra passes over the message, and to avoid extra external dependencies. Writing our own decoder will also allow us to be more efficient (and correct!) about when to decode HTML in the body.
Subject: Re: [SAdev] New: new MIME decoder Wasn't a new MIME decoder one of the main features of SA 3? Maybe we should investigate how much work SA 3 would be to get to the level we're at now.
> Wasn't a new MIME decoder one of the main features of SA 3? Maybe we > should investigate how much work SA 3 would be to get to the level > we're at now. Maybe. I don't currently believe that we should drop our current code base to switch to a new one. Rewriting specific portions of the code base has worked pretty darn well for us. Some examples: the HTML parser that replaced the original HTML substitution code, the new ArchiveIterator, and the updated locking code. There are some nice features in the SA3 decoder although it's missing some stuff I want, I might be able to add it easier than writing one from scratch. I'll take a look at SA3 and the SA3 decoder, thanks for the idea.
BTW, I think SA3 is quite a good idea. it should not be too hard to port our current codebase over to that framework, and it's certainly cleaner than what we have now.
moving a bunch of bugs to 2.70 milestone
a quick moo-haha, and the bug is mine. :)
just an update ... this is mostly in place: when a NoMailAudit object is created, the new parser generates a parse object with the appropriate data. nothing has been converted to use the new parse object yet though. fyi.
more updates ... I've merged in the new MIME parser with the text generation in PerMsgStatus. there's still some pieces that need work, but PerMsgStatus is a heck of a lot smaller, and the MIME parsing/decoding is all correct now. :)
*** Bug 2914 has been marked as a duplicate of this bug. ***
*** Bug 2628 has been marked as a duplicate of this bug. ***
ok, I'm going to call this officially closed now. the new mime parser is integrated with 2.70, and all of the related bugs were fixed. :)
*** Bug 3045 has been marked as a duplicate of this bug. ***