Bug 5920 - remove obsolete rule X_IP
Summary: remove obsolete rule X_IP
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other All
: P5 minor
Target Milestone: 3.3.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-10 01:39 UTC by Justin Mason
Modified: 2009-06-30 14:39 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
False Positive - email to beagleboard@googlegroups.com text/plain None Adam Katz [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Mason 2008-06-10 01:39:58 UTC 
http://ruleqa.spamassassin.org/20080609-r664661-n/X_IP/detail#new

0.00000   0.0216   0.0763   0.221    0.52    2.84  X_IP  

it has a very high score and hits more ham than spam nowadays.
also overlaps with lots of other better rules:

OVERLAP WITH FULL RULES:
  overlap spam: 100% of X_IP hits also hit MIME_BOUND_DD_DIGITS; 19% of MIME_BOUND_DD_DIGITS hits also hit X_IP 
  overlap spam: 100% of X_IP hits also hit MSGID_SPAM_CAPS; 19% of MSGID_SPAM_CAPS hits also hit X_IP 
  overlap spam: 100% of X_IP hits also hit RCVD_NUMERIC_HELO; 0% of RCVD_NUMERIC_HELO hits also hit X_IP 
  overlap spam: 100% of X_IP hits also hit RDNS_NONE; 0% of RDNS_NONE hits also hit X_IP 
  overlap spam: 100% of X_IP hits also hit T_BUG5868_RDNS_NONE; 0% of T_BUG5868_RDNS_NONE hits also hit X_IP 
  overlap spam:  99% of X_IP hits also hit RCVD_IN_XBL; 0% of RCVD_IN_XBL hits also hit X_IP 
  overlap spam:  98% of X_IP hits also hit MIME_QP_LONG_LINE; 4% of MIME_QP_LONG_LINE hits also hit X_IP 
  overlap spam:  98% of X_IP hits also hit T_QP_LENGTH_77_78; 0% of T_QP_LENGTH_77_78 hits also hit X_IP 
  overlap spam:  98% of X_IP hits also hit T_QP_LENGTH_78_79; 10% of T_QP_LENGTH_78_79 hits also hit X_IP
Comment 1 Adam Katz 2009-05-26 16:48:29 UTC 
Created attachment 4456 [details]
False Positive - email to beagleboard@googlegroups.com

Please escalate.  I've had to zero this score for its FPs.

Google groups email now throws this flag (see attachment).

Results from today's http://ruleqa.spamassassin.org/week/X_IP/detail include:
  SPAM% 0.0519  (527 of 1015877, overwhelmingly composed of high-scoring spam)
  HAM%  0.6687  (376 of 56225)

Currently, this is scored HIGH in v759778 of updates.spamassassin.org's 50_scores:
  score X_IP 2.840 1.943 2.744 3.177
Comment 2 Justin Mason 2009-05-27 01:49:09 UTC 
actually, all the FPS are Google Groups messages.  we may be able to fix that.

this rule may help; check out ruleqa in a day or two:

: 180...; svn commit -m "bug 5920: test replacement X_IP rule" rulesrc/sandbox/jm/20_bug_5920.cf 
Adding         rulesrc/sandbox/jm/20_bug_5920.cf
Transmitting file data .
Committed revision 779062.

header __X_IP                   exists:X-IP
header __GOOGLE_GROUPS_UA       User-Agent =~ /^G2\//

meta T_BUG5920_X_IP             (__X_IP && !__GOOGLE_GROUPS_UA)
describe T_BUG5920_X_IP         Message has X-IP header
Comment 3 Justin Mason 2009-06-30 14:39:47 UTC 
it fixed it.