Bug 7370 - NUMERIC_HTTP_ADDR misfires on numeric hostnames
Summary: NUMERIC_HTTP_ADDR misfires on numeric hostnames
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: 3.4.1
Hardware: PC Linux
: P2 minor
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-18 15:55 UTC by Kris Deugau
Modified: 2019-06-18 14:02 UTC (History)
2 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kris Deugau 2016-11-18 15:55:32 UTC 
I just received a false-positive report where NUMERIC_HTTP_ADDR fired on an all-numeric hostname part of a longer fully-qualified domain name.

The domain part of the link was:

https://2987979.fls.doubleclick.net/

Here's a suggested fix to ensure that it is really matching on the entire fully-qualified hostname part of the URI:

uri NUMERIC_HTTP_ADDR  m{^https?\://\d{7}(?:/|$)}is
Comment 1 Kevin A. McGrail 2018-08-26 21:46:20 UTC 
That fix won't work because I think he's really just looking for at least 7 numbers not exactly 7 numbers
Comment 2 Henrik Krohns 2019-06-18 14:02:25 UTC 
Who knows what the rules original intention was. Doesn't even hit anything right now. Fixing it to match only numeric/ips.

Sending        rules/20_uri_tests.cf
Transmitting file data .done
Committing transaction...
Committed revision 1861579.