Bug 7631 - Added column last_hit without documentation or reflected in Upgrade file
Summary: Added column last_hit without documentation or reflected in Upgrade file
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamassassin (show other bugs)
Version: 3.4.2
Hardware: PC Windows NT
: P2 blocker
Target Milestone: 3.4.3
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-19 17:24 UTC by Kevin A. McGrail
Modified: 2018-10-28 19:47 UTC (History)
3 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin A. McGrail 2018-09-19 17:24:30 UTC 
reported by Alex Woick <alex@wombaz.de> on list:

- upon starting spamd, I got this message in the system log:

auto-whitelist: sql-based get_addr_entry ignore@compiling.spamassassin.taint.org|none: SQL error: Unknown column 'last_hit' in 'order clause'

It seems this column is added for 3.4.2, but it is not documented in the update notes. It's not even present in the CREATE TABLE statement in SQLBasedAddrList.pm. Should probably be added. I assume it is a auto-updating TIMESTAMP column purely for documentation like this:

`last_hit` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
Comment 1 Philippe Chaintreuil 2018-10-18 10:57:46 UTC 
This seems to have come out of this change: https://svn.apache.org/viewvc?view=revision&revision=1698165

I'm not sure what it's fixing though.  Is this function shared between AWL & TxRep?
Comment 2 Giovanni Bechis 2018-10-19 06:50:35 UTC 
SQLBasedAddrList.pm is used by TxRep and by AWL plugin as well,
the last_hit field should be added to awl database as well.
Comment 3 Giovanni Bechis 2018-10-21 12:11:33 UTC 
Fixed in r1844485.
Comment 4 Philippe Chaintreuil 2018-10-28 19:47:42 UTC 
Actually, the issue appears in 3.4.1, but the UPGRADE notes make it sound like it didn't start until after 3.4.1.  This seems confusing.