my +1 to removing

I don't even know what it does because I think the term HashCash has morphed over the decades.

+1 to kill it

Done.

Notice that trunk/rules/init.pre with hashcash removed completely will end up in next 3.4.3 rc release, so it will not be active for any _new_ 3.4.3 installations. Old installations will not have init.pre overwritten, so I don't feel there is any reason to include this in 3.4 UPGRADE notes.

It's also removed from current rules. In the 0.00000001% chance that someone is actually using this, they can create the rules locally..

Sending        trunk/MANIFEST
Sending        trunk/UPGRADE
Sending        trunk/USAGE
Sending        trunk/rules/30_text_de.cf
Sending        trunk/rules/30_text_pt_br.cf
Sending        trunk/rules/50_scores.cf
Sending        trunk/rules/init.pre
Sending        trunk/rulesrc/10_force_active.cf
Sending        trunk/spamassassin.raw
Sending        trunk/t/all_modules.t
Sending        trunk/t/data/01_test_rules.cf
Sending        trunk/t/data/01_test_rules.pre
Sending        trunk/t/debug.t
Transmitting file data .............done
Committing transaction...
Committed revision 1862148.

All I know is now I am getting warnings

warn: plugin: failed to parse plugin (from @INC): Can't locate
Mail/SpamAssassin/Plugin/Hashcash.pm in @INC

because though present in
share/perl/5.28.1/Mail/SpamAssassin/Plugin
it is not present in
share/perl/5.30.0/Mail/SpamAssassin/Plugin

however other parts of the code are still trying to invoke it, despite
svn update; make clean; perl Makefile.PL; make; make install
etc.

I probably have to remove everything and reinstall to finally stop the errors!

(In reply to jidanni from comment #5)

> I probably have to remove everything and reinstall to finally stop the
> errors!

OR just fix your init.pre file to remove the directive to load the HashCash plugin.

OK, from now on I'll do rm -rf $PREFIX before doing the make stuff. Removes 90% of the cruft mounting up too!

(In reply to jidanni from comment #7)
> OK, from now on I'll do rm -rf $PREFIX before doing the make stuff. Removes
> 90% of the cruft mounting up too!

There's no reason to do that, and you also destroy your settings etc.

Removing HashCash was a rare occurence of removing ancient plugin/code that should never be run, even if some user has it loaded in some configs. Simply remove the loadplugin clause, there's nothing more to it.

I've added check to load_plugin() to warn gracefully about things like this.

  # Bug 7728
  if ($package eq 'Mail::SpamAssassin::Plugin::HashCash') {
    warn "plugin: $package is deprecated, remove loadplugin clause from your configuration\n";
    return;
  }

Sending        lib/Mail/SpamAssassin/PluginHandler.pm
Transmitting file data .done
Committing transaction...
Committed revision 1874052.

Henrik, can you submit that to 3.4 as well?  I'm coming up for air and will get 3.4.5 built.

(In reply to Kevin A. McGrail from comment #10)
> Henrik, can you submit that to 3.4 as well?  I'm coming up for air and will
> get 3.4.5 built.

Hashcash is still found in 3.4 branch, I don't see any need touch anything?

Ahh good point.  Ignore me. I've been installing 3.4.4, 3.4.5 and trunk and mixed up my brain.