Bug 7840 - description exists for non-existent rule USER_IN_WELCOMELIST_TO
Summary: description exists for non-existent rule USER_IN_WELCOMELIST_TO
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: 3.4.2
Hardware: PC Linux
: P2 normal
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-15 10:23 UTC by Sebastian J. Bronner
Modified: 2020-07-20 10:11 UTC (History)
4 users (show)



Attachment Type Modified Status Actions Submitter/CLA Status

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian J. Bronner 2020-07-15 10:23:18 UTC
Almost all instances of USER_IN_WELCOMELIST_TO are conditional, but not the translations of the description:

30_text_de.cf:335
30_text_fr.cf:254
30_text_pl.cf:240
30_text_pt_br.cf:57

This causes the configuration parser to emit a warning. And that, in turn, causes sa-update to abort.

See also the ongoing discussion in #7826.
Comment 1 Sebastian J. Bronner 2020-07-15 10:27:28 UTC
I meant: See also the ongoing discussion in bug 7826.
Comment 2 Kevin A. McGrail 2020-07-15 10:31:00 UTC
This is a lint warning.  A fix was committed a few days ago but I had to work
out a merge complaint on the rule system publishing this morning.  I
believe a fix is now published.

Can you try now and lmk, please?  I think the current ruleset is 1879881
has it fixed and is published.

However SA 3.4.3+ will still install updates with just a warning.  Can
you upgrade your SA or are you stuck at 3.4.2?

If you still show the issue, what is the output of this command?
 sa-update -D --checkonly 2>&1 | grep -i dns
Comment 3 Kevin A. McGrail 2020-07-15 11:58:00 UTC
This issue only happens with 3.4.2 and before where a lint warning causes a failure.

Recommend updating but I'm working on a fix with rules.
Comment 4 Kevin A. McGrail 2020-07-15 12:04:02 UTC
OK, this should be fixed with the next rules publication with this commit included.  

svn commit -m 'Much cleaner to keep one rule name but use a if condition to set which eval is called.  This fixes bug 7840'
Sending        rules/50_scores.cf
Sending        rules/60_whitelist.cf
Transmitting file data ..
Committed revision 1879885.
Comment 5 Kevin A. McGrail 2020-07-16 20:22:55 UTC
I believe ruleset 1879934 has been published and should fix the issue.  Can
anyone confirm, please?
Comment 6 yannik 2020-07-17 09:30:13 UTC
SA 3.4.2 is the latest version available on debian stable (buster). 

Therefore this version is probably in use by many people.

I just tried sa-update, but it still fails:

$ date
Fr 17. Jul 11:27:35 CEST 2020
$ sa-update -v
Update available for channel updates.spamassassin.org: 1879434 -> 1879882
http: (curl) GET http://sa-update.razx.cloud/1879882.tar.gz, success
http: (curl) GET http://sa-update.razx.cloud/1879882.tar.gz.sha512, success
http: (curl) GET http://sa-update.razx.cloud/1879882.tar.gz.sha256, success
http: (curl) GET http://sa-update.razx.cloud/1879882.tar.gz.asc, success
config: warning: description exists for non-existent rule USER_IN_WELCOMELIST_TO

channel: lint check of update failed, channel failed
Update failed, exiting with code 4
Comment 7 Sebastian J. Bronner 2020-07-17 09:34:33 UTC
Thanks Kevin, for responding so fast. It seems that your changes aren't yet published on all mirrors:

$ /usr/bin/sa-update -D --checkonly 2>&1 | grep -i dns
Jul 17 11:28:29.942 [28189] dbg: diag: [...] module installed: Net::DNS, version 1.1
Jul 17 11:28:29.943 [28189] dbg: diag: [...] module installed: Net::DNS::Nameserver, version 1558
Jul 17 11:28:29.966 [28189] dbg: dns: 2.4.3.updates.spamassassin.org => 1879882, parsed as 1879882

For the moment, I am still stuck with 3.4.2. I will be upgrading to Ubuntu 20.04 with 3.4.4 as time allows, but that will still be a while.
Comment 8 Kevin A. McGrail 2020-07-17 17:00:52 UTC
Ty, working to figure out why the fix isn't being published in the rules
Comment 9 Bill Cole 2020-07-18 02:59:17 UTC
(In reply to Kevin A. McGrail from comment #8)
> Ty, working to figure out why the fix isn't being published in the rules

It's an update timing issue. The latest rev to be published is r1879882 but the fix was in r1879885:

    # svn log rules/60_whitelist.cf |head -5
    ------------------------------------------------------------------------
    r1879885 | kmcgrail | 2020-07-15 08:02:46 -0400 (Wed, 15 Jul 2020) | 1 line
    
    Much cleaner to keep one rule name but use a if condition to set which eval is called.  This fixes bug 7840
    ------------------------------------------------------------------------

And as noted in bug 7838: this is a transient noise problem, because there are no functional changes to actual rules since this problem arose.
Comment 10 Kevin A. McGrail 2020-07-18 20:52:27 UTC
Thanks Bill for that insight.  

I show the ruleset 1879934 was published and has the fix.  Please confirm if you can update now.
Comment 11 Sebastian J. Bronner 2020-07-20 10:11:22 UTC
Yes. I can confirm the absence of a warning as well as a successuful sa-update run.

Thank you.