Bug 7843 - mkupdates version testing
Summary: mkupdates version testing
Status: NEW
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Masses (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: All All
: P2 enhancement
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-26 16:02 UTC by Henrik Krohns
Modified: 2020-07-28 10:37 UTC (History)
1 user (show)



Attachment Type Modified Status Actions Submitter/CLA Status

Note You need to log in before you can comment on or make changes to this bug.
Description Henrik Krohns 2020-07-26 16:02:28 UTC
It seems mkupdate-with-scores runs sa-update/lint tests for multiple versions, currently 3.4.1 - 3.4.4. But it proceeds even if only one of them succeeds. It would seem more appropriate to require all of them passing to publish rules. Also trunk should be added for testing.

The current code can be found near the end of mkupdate-with-scores and is pretty self explaining.

...
# test to make sure it works with sa-update --install
TESTED_VERSIONS=""

MAJOR_VERS=3
for (( MINOR_VERS=4; 1; MINOR_VERS++ )); do
  for (( UPDATE_VERS=1; 1; UPDATE_VERS++ )); do
...
# publish update
if [[ ! -z "$TESTED_VERSIONS" ]]; then
...
Comment 1 Henrik Krohns 2020-07-28 10:37:43 UTC
Btw mkupdates/run_nightly that runs every day few hours after mkupdate-with-scores, also does some lints but only for 3.4.4 it seems. It however tries to reuse the rule tarball from mkupdate-with-scores if it exists etc. Hopefully someone will have time to clear these and carefully validate rule tarballs with several old and new versions before publishing.