7994 – Plugin ASN.pm, AskDNS.pm: return early if $pkt is undefined

Bug 7994 - Plugin ASN.pm, AskDNS.pm: return early if $pkt is undefined

Summary: Plugin ASN.pm, AskDNS.pm: return early if $pkt is undefined

Status:	RESOLVED FIXED

Alias:	None

Product:	Spamassassin
Classification:	Unclassified
Component:	Plugins (show other bugs)
Version:	4.0.0
Hardware:	All All

Importance:	P2 enhancement
Target Milestone:	Undefined
Assignee:	SpamAssassin Developer Mailing List

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2022-05-17 15:22 UTC by Michael Storz
Modified:	2022-05-20 08:52 UTC (History)
CC List:	1 user (show)

Attachment	Type	Modified	Status	Actions	Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Storz 2022-05-17 15:22:23 UTC

Both plugins have a comment

  # NOTE: $pkt will be undef if the DNS query was aborted (e.g. timed out)

However, instead of returning immediately, the plugins go on, but at the end do nothing. This makes the understanding of the code more difficult than needed.

Comment 1 Henrik Krohns 2022-05-20 08:52:43 UTC

Quick cleanup done..

Committed revision 1901082.