Bug 8062 - [review] no URL makes uridnsbl rules "unrun"
Summary: [review] no URL makes uridnsbl rules "unrun"
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Plugins (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: All All
: P2 blocker
Target Milestone: 4.0.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on: 7735
Blocks:
  Show dependency tree
 
Reported: 2022-10-14 10:11 UTC by Henrik Krohns
Modified: 2022-10-24 14:03 UTC (History)
6 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
possible fix patch None Wolfgang Breyha [NoCLA]
Fix unused rules patch None Henrik Krohns [HasCLA]
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Henrik Krohns 2022-10-14 10:11:14 UTC 
On sa-users list from Wolfgang Breyha:


If a scanned E-Mail does not contain any URL (URIHOSTS and URIDOMAINS empty)
SA4(rc3) does not mark rules using check_uridnsbl as "run" IMO.

This makes meta rules depending on them "unrunable" as well.

Dbg Output from an example:
> Oct 14 11:51:01.140 [3032346] dbg: check: tagrun - tag URIHOSTS is now ready, value: ARY:[]
> Oct 14 11:51:01.140 [3032346] dbg: check: tagrun - tag URIDOMAINS is now ready, value: ARY:[]
...
> Oct 14 11:51:01.215 [3032346] dbg: rules-all: running eval rule URIBL_BLACK (check_uridnsbl)
...
> Oct 14 11:51:47.392 [3032346] dbg: rules-all: unrun dependencies prevented meta SPF_PASS_SPAM from running: URIBL_BLACK
Comment 1 Wolfgang Breyha 2022-10-14 14:19:03 UTC 
Created attachment 5846 [details]
possible fix

I'm currently trying attached patch. At least with my testcases it looks promising.
Comment 2 Henrik Krohns 2022-10-15 11:17:27 UTC 
Created attachment 5847 [details]
Fix unused rules

Here's my patch so no to need hassle with ICLA.. reuses the previously unused uridnsbl_activerules variable and checks that bgsend succeeded. Vote to commit.
Comment 3 Bill Cole 2022-10-15 14:30:50 UTC 
+1 TO COMMIT
Comment 4 Kevin A. McGrail 2022-10-24 13:58:42 UTC 
+1 from me as well, ty  this should close 7736 as well, I believe.
Comment 5 Giovanni Bechis 2022-10-24 14:00:44 UTC 
+1 to commit
Comment 6 Henrik Krohns 2022-10-24 14:03:25 UTC 
Sending        trunk/lib/Mail/SpamAssassin/Plugin/URIDNSBL.pm
Transmitting file data .done
Committing transaction...
Committed revision 1904811.