Bug 8234 - Honor uridnsbl_skip_domain in DNSEval
Summary: Honor uridnsbl_skip_domain in DNSEval
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: PC Linux
: P2 normal
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-11 14:38 UTC by Giovanni Bechis
Modified: 2024-04-16 09:32 UTC (History)
3 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
uridnsbl_skip_domain for DNSEval patch None Giovanni Bechis [HasCLA]
uridnsbl_skip_domain for DNSEval patch None Giovanni Bechis [HasCLA]
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Giovanni Bechis 2024-04-11 14:38:01 UTC 
Created attachment 5949 [details]
uridnsbl_skip_domain for DNSEval

uridnsbl_skip_domain option can be used to prevent SA from running rbl lookups on a particular domain.
This option is honored in URIDNSBL and HashBL plugins but not in DNSEval plugin.

The attached diff makes DNSEval honor uridnsbl_skip_domain option.
This is a behavior change but I think it should be expected.
Comment 1 Kevin A. McGrail 2024-04-12 04:29:24 UTC 
+1 from me.
Comment 2 Henrik Krohns 2024-04-12 04:47:24 UTC 
- missing dbg("dnseval:
- should subdomain.foo.com match uridnsbl_skip_domain foo.com?
Comment 3 Giovanni Bechis 2024-04-12 09:10:20 UTC 
Created attachment 5950 [details]
uridnsbl_skip_domain for DNSEval

added "dnseval:" prefix to dbg calls.
subdomains are skipped as well if the parent domain is in uridnsbl_skip_domain config. This is the same behavior than we have in HashBL plugin.
Comment 4 Giovanni Bechis 2024-04-16 09:32:57 UTC 
Sending        lib/Mail/SpamAssassin/Plugin/DNSEval.pm
Transmitting file data .done
Committing transaction...
Committed revision 1917016.