Created attachment 5952 [details]
patch file for validity dnsbl

Attached is a patch for your review to update the DNSBL rules recently implemented for Validity IP blocking. After analyzing our DNS logs following the recent changes in bug ID 8233, we don't think they are behaving in a way that was intended. The attached patch is much more effective and efficient rule set.

The rules were tested against a local DNS instance using the spamassassin cli:
perl -T ./spamassassin -t -D < ./t/data/spam/001

blocked output:

 pts rule name              description                                                                                                                                                                                                                                                                                                                                            
---- ---------------------- --------------------------------------------------                                                                                                                                                                                                                                                                                                     
 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to                                                                                                                                                                                                                                                                                                         
                             Validity was blocked.  See                                                                                                                                                                                                                                                                                                                            
                            https://knowledge.validity.com/hc/en-us/articles/20961730681243                                                                                                                                                                                                                                                                                        
                             for more information.                                                                                                                                                                                                                                                                                                                                 
                          [193.120.211.219 listed in bl.score.senderscore.com]                                                                                                                                                                                                                                                                                                     
 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to                                                                                                                                                                                                                                                                                                         
                             Validity was blocked.  See                                                                                                                                                                                                                                                                                                                            
                            https://knowledge.validity.com/hc/en-us/articles/20961730681243                                                                                                                                                                                                                                                                                        
                             for more information.                                                                                                                                                                                                                                                                                                                                 
                            [193.120.211.219 listed in sa-accredit.habeas.com]                                                       
 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The                                                               
                            query to Validity was blocked.  See                                                                      
                            https://knowledge.validity.com/hc/en-us/articles/20961730681243                                          
                             for more information.                                                                                   
                       [193.120.211.219 listed in sa-trusted.bondedsender.org]