Bug 28379 - Extended debug output
Summary: Extended debug output
Status: RESOLVED FIXED
Alias: None
Product: Slide
Classification: Unclassified
Component: WebDAV client (show other bugs)
Version: 2.0
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---
Assignee: Slide Developer List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-14 14:16 UTC by Thomas Bernert
Modified: 2004-11-16 19:05 UTC (History)
0 users



Attachments
changes of extented debug output (22.76 KB, patch)
2004-04-14 14:17 UTC, Thomas Bernert
Details | Diff
http headers add to debug output! (11.56 KB, patch)
2004-04-15 14:38 UTC, Thomas Bernert
Details | Diff
Additional debugoutputs of remaining WebDAV-methods. (22.03 KB, patch)
2004-04-21 14:00 UTC, Thomas Bernert
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Bernert 2004-04-14 14:16:26 UTC
hi there,
I extended the debug output of client: if you set the debug option to ON (debug 
on), the client will print out the XML communication stream between client and 
server.
Comment 1 Thomas Bernert 2004-04-14 14:17:12 UTC
Created attachment 11227 [details]
changes of extented debug output
Comment 2 Eric Johnson 2004-04-14 15:21:51 UTC
Why not just turn on HttpClient's wire.log output?

I note, also that bug 28302 for HttpClient is precisely about separating the
wire-log of the content of the request from the headers.

Mind you, I'm not for or against this patch per-se, I just wanted to understand
the motivation, of a not-quite-redundant solution a little better.
Comment 3 Oliver Zeigermann 2004-04-15 07:15:42 UTC
Hmmm, does HttpClient's wire.log output offer formatted XML output?
Comment 4 Thomas Bernert 2004-04-15 14:38:39 UTC
Created attachment 11248 [details]
http headers add to debug output!
Comment 5 Eric Johnson 2004-04-15 15:29:55 UTC
Of course, HttpClient doesn't do anything with the output it is given, so its
wire log will not be nicely formatted.  I think I may have misunderstood the
patch the first time around.  I see now that it doesn't actually *output*
anything, it merely formats.  Perhaps this should be the behavior always, though?

The 11248 patch is more problematic in this regard, because it does output
exactly the same headers that HttpClient wire-log support will give you.
Comment 6 Oliver Zeigermann 2004-04-15 15:38:54 UTC
I see, but as far as I know, there is no way to configure this at runtime using
the debug on command, right? The only way I could enable the wire-log thing was
to configure it in log4j. Is this is encapsulated by commons logging and the
underlying logger might well be the one of jdk1.4 I see no way to *dynamically*
switch this debug logging on or off. 

Another pro to patch #11248 is that it always logs to system out, while the
ordinary logging will go into a file. Additionally, it is much less convenient
to take one part of the information (formatted and unchuncked XML) from one
source and the headers from another on. 

Note, this patch only gets active when you explicitly switch on debugging using
the debug on command.

Because of this I think it is a patch worth to be accepted.
Comment 7 Oliver Zeigermann 2004-04-19 07:59:54 UTC
Patch applied
Comment 8 Thomas Bernert 2004-04-21 13:57:54 UTC
Sorry, there are still some method without debug information.
Comment 9 Thomas Bernert 2004-04-21 14:00:14 UTC
Created attachment 11302 [details]
Additional debugoutputs of remaining WebDAV-methods.
Comment 10 Oliver Zeigermann 2004-04-22 07:05:31 UTC
Patch applied