Bug 48501 - Log rotation for ISAPI Redirector
Summary: Log rotation for ISAPI Redirector
Status: RESOLVED FIXED
Alias: None
Product: Tomcat Connectors
Classification: Unclassified
Component: isapi (show other bugs)
Version: unspecified
Hardware: PC Mac OS X 10.4
: P2 enhancement (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-07 00:48 UTC by Tim Whittington
Modified: 2011-03-07 05:06 UTC (History)
0 users


Attachments
PATCH - ISAPI Redirector with rotatelogs functionality (8.86 KB, text/plain)
2010-01-07 00:48 UTC, Tim Whittington 		Details
PATCH - ISAPI Redirector doc updates (14.32 KB, patch)
2010-01-07 00:49 UTC, Tim Whittington 		Details | Diff
PATCH - ISAPI Redirector with rotatelogs functionality (8.98 KB, patch)
2010-01-07 01:24 UTC, Tim Whittington 		Details | Diff
PATCH - ISAPI Redirector with rotatelogs functionality (13.24 KB, patch)
2010-01-07 12:40 UTC, Tim Whittington 		Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Whittington 2010-01-07 00:48:53 UTC 
Created attachment 24810 [details]
PATCH - ISAPI Redirector with rotatelogs functionality

Apache supports log rotation through piped logging to the rotatelogs program.

Attached are patches to provide equivalent functionality in the IIS ISAPI Redirector.
Comment 1 Tim Whittington 2010-01-07 00:49:51 UTC 
Created attachment 24811 [details]
PATCH - ISAPI Redirector doc updates
Comment 2 Mladen Turk 2010-01-07 01:09:27 UTC 
_ftell_nlock does not exist with older MSVC versions.
It was introduced with Visual Studio 2005
Comment 3 Tim Whittington 2010-01-07 01:24:41 UTC 
Created attachment 24812 [details]
PATCH - ISAPI Redirector with rotatelogs functionality

Updated the patch to only use _ftell_nolock when available.
Comment 4 Tim Whittington 2010-01-07 12:40:08 UTC 
Created attachment 24815 [details]
PATCH - ISAPI Redirector with rotatelogs functionality

Attached updated patch with a couple of changes:
* Using GetFileSizeEx on suggestion from Mladen (fixes log size determination with multiple IIS processes and adds 64bit file size support)
* Added support for optional use of an M suffix on log_filesize setting, as used in rotatelogs

(Combined doc updates into this patch as well)
Comment 5 Tim Whittington 2010-03-07 20:46:04 UTC 
Implementation of this is now committed to trunk.
Comment 6 Mark Thomas 2011-03-07 05:06:40 UTC 
This was included in 1.2.31 onwards