Bug 51168 - mod_status Total Traffic won't take account of internal-redirected requests
Summary: mod_status Total Traffic won't take account of internal-redirected requests
Status: RESOLVED LATER
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: Core (show other bugs)
Version: 2.0.63
Hardware: PC All
: P2 normal (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords: MassUpdate, PatchAvailable
Depends on:
Blocks:
 
Reported: 2011-05-08 05:00 UTC by Tiberius Teng
Modified: 2018-11-07 21:08 UTC (History)
0 users



Attachments
patch scoreboard.c to use final served response size (628 bytes, patch)
2011-05-08 05:00 UTC, Tiberius Teng
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tiberius Teng 2011-05-08 05:00:40 UTC
Created attachment 26969 [details]
patch scoreboard.c to use final served response size

I've just noticed that when a request is rewrited by mod_rewrite, its
traffic won't be accounted into "Total Traffic" by mod_status.

I'm using Apache/2.0.63 on freebsd (stock ports), experiments are
preformed in the following way:

dd if=/dev/urandom of=10m_file bs=1048576 count=10
cat > .htaccess
RewriteEngine On
RewriteRule ^10m_rw$ 10_file
^D

curl -v 'http://192.168.1.1/server-status?auto'  # take a note of
Total kBytes field
curl -v 'http://192.168.1.1/10m_file' -o 10m_tmp
curl -v 'http://192.168.1.1/server-status?auto'  # Total kBytes field
do increment about ~10MB
curl -v 'http://192.168.1.1/10m_rw' -o 10m_tmp
curl -v 'http://192.168.1.1/server-status?auto'  # Total kBytes field
only increases a few hundred kB's

I've found the problem is that when scoreboard.c incrementing counters it won't check if the request is being redirected, thus ignoring the new request_rec struct chain pointed by 'next' field. It always use the original request_rec for bytes_sent accounting, which is potentially wrong.

The patch applied will make scoreboard.c use bytes_sent of final served response as the increment value.
Comment 1 William A. Rowe Jr. 2018-11-07 21:08:52 UTC
Please help us to refine our list of open and current defects; this is a mass update of old and inactive Bugzilla reports which reflect user error, already resolved defects, and still-existing defects in httpd.

As repeatedly announced, the Apache HTTP Server Project has discontinued all development and patch review of the 2.2.x series of releases. The final release 2.2.34 was published in July 2017, and no further evaluation of bug reports or security risks will be considered or published for 2.2.x releases. All reports older than 2.4.x have been updated to status RESOLVED/LATER; no further action is expected unless the report still applies to a current version of httpd.

If your report represented a question or confusion about how to use an httpd feature, an unexpected server behavior, problems building or installing httpd, or working with an external component (a third party module, browser etc.) we ask you to start by bringing your question to the User Support and Discussion mailing list, see [https://httpd.apache.org/lists.html#http-users] for details. Include a link to this Bugzilla report for completeness with your question.

If your report was clearly a defect in httpd or a feature request, we ask that you retest using a modern httpd release (2.4.33 or later) released in the past year. If it can be reproduced, please reopen this bug and change the Version field above to the httpd version you have reconfirmed with.

Your help in identifying defects or enhancements still applicable to the current httpd server software release is greatly appreciated.