Bug 58396 - Data race on field org.apache.tomcat.util.net.NioEndpoint$Poller.nextExpiration
Summary: Data race on field org.apache.tomcat.util.net.NioEndpoint$Poller.nextExpiration
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 8
Classification: Unclassified
Component: Util (show other bugs)
Version: 8.0.x-trunk
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: ----
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
: 58400 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-09-12 17:10 UTC by Yilong Li
Modified: 2015-09-18 09:00 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yilong Li 2015-09-12 17:10:52 UTC 
Reported by RV-Predict (a dynamic race detector) when running the test suite:
Data race on field org.apache.tomcat.util.net.NioEndpoint$Poller.nextExpiration: {{{
    Concurrent write in thread T19 (locks held: {Monitor@684fa488})
 ---->  at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:898)
        at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:609)
        at org.apache.coyote.http11.AbstractHttp11Processor.action(AbstractHttp11Processor.java:865)
        at org.apache.coyote.Request.action(Request.java:378)
        at org.apache.catalina.core.AsyncContextImpl.dispatch(AsyncContextImpl.java:231)
        - locked Monitor@684fa488 at org.apache.catalina.core.AsyncContextImpl.dispatch(AsyncContextImpl.java:192)
        at org.apache.catalina.core.AsyncContextImpl.dispatch(AsyncContextImpl.java:187)
        at org.apache.catalina.core.TestAsyncContextImpl$DispatchingServlet$1.run(TestAsyncContextImpl.java:710)
    T19 is created by T18
        at org.apache.catalina.core.TestAsyncContextImpl$DispatchingServlet.doGet(TestAsyncContextImpl.java:715)

    Concurrent read in thread T16 (locks held: {})
 ---->  at org.apache.tomcat.util.net.NioEndpoint$Poller.timeout(NioEndpoint.java:1275)
        at org.apache.tomcat.util.net.NioEndpoint$Poller.run(NioEndpoint.java:1092)
    T16 is created by T1
        at org.apache.tomcat.util.net.NioEndpoint.startInternal(NioEndpoint.java:426)
}}} 

Data race on field org.apache.tomcat.util.net.NioEndpoint$Poller.nextExpiration: {{{
    Concurrent write in thread T19 (locks held: {Monitor@684fa488})
 ---->  at org.apache.tomcat.util.net.NioEndpoint$Poller.add(NioEndpoint.java:898)
        at org.apache.tomcat.util.net.NioEndpoint.processSocket(NioEndpoint.java:609)
        at org.apache.coyote.http11.AbstractHttp11Processor.action(AbstractHttp11Processor.java:865)
        at org.apache.coyote.Request.action(Request.java:378)
        at org.apache.catalina.core.AsyncContextImpl.dispatch(AsyncContextImpl.java:231)
        - locked Monitor@684fa488 at org.apache.catalina.core.AsyncContextImpl.dispatch(AsyncContextImpl.java:192)
        at org.apache.catalina.core.AsyncContextImpl.dispatch(AsyncContextImpl.java:187)
        at org.apache.catalina.core.TestAsyncContextImpl$DispatchingServlet$1.run(TestAsyncContextImpl.java:710)
    T19 is created by T18
        at org.apache.catalina.core.TestAsyncContextImpl$DispatchingServlet.doGet(TestAsyncContextImpl.java:715)

    Concurrent read in thread T16 (locks held: {})
 ---->  at org.apache.tomcat.util.net.NioEndpoint$Poller.timeout(NioEndpoint.java:1337)
        at org.apache.tomcat.util.net.NioEndpoint$Poller.run(NioEndpoint.java:1092)
    T16 is created by T1
        at org.apache.tomcat.util.net.NioEndpoint.startInternal(NioEndpoint.java:426)
}}}
Comment 1 Mark Thomas 2015-09-17 21:09:54 UTC 
This was already fixed in trunk due to the connector clean-up. I've back-ported tjhe fix to 8.0.x for 8.0.27 onwards.
Comment 2 Mark Thomas 2015-09-18 09:00:42 UTC 
*** Bug 58400 has been marked as a duplicate of this bug. ***