Bug 67005 - XSLFPictureShape - audio-related methods
Summary: XSLFPictureShape - audio-related methods
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: XSLF (show other bugs)
Version: 5.3.x-dev
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-18 20:28 UTC by Max
Modified: 2023-09-17 16:34 UTC (History)
0 users


Attachments
Patch (3.13 KB, message/rfc822)
2023-08-18 20:28 UTC, Max 		Details
Patch (103.06 KB, patch)
2023-08-18 20:32 UTC, Max 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Max 2023-08-18 20:28:53 UTC 
Created attachment 38857 [details]
Patch

I needed audio-related methods similar to the ones added for videos in https://bz.apache.org/bugzilla/show_bug.cgi?id=65674.
Suggesting a patch with the methods.
Comment 1 Max 2023-08-18 20:32:00 UTC 
Created attachment 38858 [details]
Patch
Comment 2 PJ Fanning 2023-08-18 21:26:14 UTC 
Does this need to be on XSLFPictureShape? Aren't sound and pictures different things?
Comment 3 Max 2023-08-19 08:10:43 UTC 
According to http://officeopenxml.com/prSlide-multiMedia.php:
"Multimedia such as a video or audio clip is added to a presentation as a property of a picture or shape".

And PowerPoint does create a <p:pic> element with the structure described in the linked article when adding an audio:
<p:pic>
    <p:nvPicPr>
        ...
        <p:nvPr>
            <a:audioFile r:link="rId2"/>
            ...
        </p:nvPr>
    </p:nvPicPr>
    ...
</p:pic>

Please see the test file from the patch as an example.
Comment 4 PJ Fanning 2023-09-14 14:58:14 UTC 
merged with r1912315