This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | "OK" button is not activated on PHP option panel | ||
---|---|---|---|
Product: | php | Reporter: | Masaki Katakai <masaki> |
Component: | Project | Assignee: | Tomas Mysik <tmysik> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | ppisl |
Priority: | P3 | ||
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | screenshot |
Description
Masaki Katakai
2008-08-21 08:40:35 UTC
Created attachment 68003 [details]
screenshot
From the screenshot I can see that you have to select a valid PHP 5 interpreter - it is not done as you can see from the error. Closing as INVALID, if you disagree, feel free to reopen and provide reasons why this state should be valid. Thanks. Thank you for the evaluation. I want a fix of this issue because it happens just when users click PHP tab and click cancel. The brank field is the default value of the setting, users do not know the setting is invalid when they click Cancel button. The error message is not shown when users click PHP tab. Even when users do not have PHP in their system, users may click PHP tab. The main issue is that there is no workaround to activate OK button again. What do you think? OK, I understand your comments but still have doubts about missing PHP interpreter (would anyone *really* use PHP build *without* PHP itself installed?). I propose to change the error about missing PHP interpreter to warning - do you agree? Thanks. Adding Petr to CC so he can comment. User has to be able to press OK button with the default state of every tab. We shouldn't required the php interpreter when the by default is not there. The warning can be enough. Or have a check that we will allow the default value as well. > We shouldn't required the php interpreter when the by default is not there.
The problem is that we *can't* have any default value here - we are just trying to find a valid PHP intepreter. I will
change it to a warning.
Fixed, please verify. http://hg.netbeans.org/main/rev/4f1a1a192f82 Integrated into 'main-golden', available in build *200808221401* on http://bits.netbeans.org/dev/nightly/ Changeset: http://hg.netbeans.org/main/rev/4f1a1a192f82 User: Tomas Mysik <tmysik@netbeans.org> Log: #144680: "OK" button is not activated on PHP option panel It's great! Thank you for quick fixing. I verified that the issue does not happen on 200808230201. I'm reopening the issue because the warning is hard to notice. I would change its text color to red and add "Warning: " at the beginning. I expect it's easy to fix. > I'm reopening the issue because the warning is hard to notice. I would change its text color to red and
> add "Warning: " at the beginning. I expect it's easy to fix.
Closing because only errors have red color (or is there any "red" warning in the IDE?). The warning has correct color
for warnings [errorLabel.setForeground(UIManager.getColor("nb.warningForeground"))] so if you are not satisfied with
the current value, feel free to file a new issue against proper module (sorry, no idea which one it is).
Well, since this is a general agreement, I have no more objections. |