This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 144680 - "OK" button is not activated on PHP option panel
Summary: "OK" button is not activated on PHP option panel
Status: VERIFIED FIXED
Alias: None
Product: php
Classification: Unclassified
Component: Project (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Tomas Mysik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-21 08:40 UTC by Masaki Katakai
Modified: 2008-12-23 19:32 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
screenshot (86.30 KB, image/png)
2008-08-21 08:48 UTC, Masaki Katakai
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Masaki Katakai 2008-08-21 08:40:35 UTC
Product Version: NetBeans IDE Dev (Build 200808191401)
Java: 1.5.0_13; Java HotSpot(TM) Client VM 1.5.0_13-119
System: Mac OS X version 10.5.4 running on i386; UTF8; en (nb)
I tried it on Windows too.

I got this issue from community folk in Japan. "OK" button
of PHP option panel is not activated again once PHP tab is
selected and closed. The following is the exact steps,

1. Start NetBeans
2. Open option dialog
3. Select PHP tab
4. Cancel to close it
5. Open option dialog again
   Now "OK" can not be selected because it's inactive.

After I select other tab and close it by Cancel button,
the "OK" button is still inactive when it's invoked next time.

Please change to proper category/subcategory if it's not
a problem of PHP.
Comment 1 Masaki Katakai 2008-08-21 08:48:47 UTC
Created attachment 68003 [details]
screenshot
Comment 2 Tomas Mysik 2008-08-21 13:31:20 UTC
From the screenshot I can see that you have to select a valid PHP 5 interpreter - it is not done as you can see from 
the error. Closing as INVALID, if you disagree, feel free to reopen and provide reasons why this state should be 
valid. Thanks.
Comment 3 Masaki Katakai 2008-08-21 17:26:11 UTC
Thank you for the evaluation.

I want a fix of this issue because it happens just when users click PHP tab and click cancel.

The brank field is the default value of the setting, users do not know the setting is invalid
when they click Cancel button. The error message is not shown when users click PHP tab.
Even when users do not have PHP in their system, users may click PHP tab. The main issue
is that there is no workaround to activate OK button again. What do you think?
Comment 4 Tomas Mysik 2008-08-22 09:00:53 UTC
OK, I understand your comments but still have doubts about missing PHP interpreter (would anyone *really* use PHP 
build *without* PHP itself installed?). I propose to change the error about missing PHP interpreter to warning - do 
you agree? Thanks.
Adding Petr to CC so he can comment.
Comment 5 Petr Pisl 2008-08-22 09:24:14 UTC
User has to  be able to press OK button with the default state of every tab. We shouldn't required the php interpreter
when the by default is not there. The warning can be enough. Or have a check that we will allow the default value as well.
Comment 6 Tomas Mysik 2008-08-22 09:40:39 UTC
> We shouldn't required the php interpreter when the by default is not there.

The problem is that we *can't* have any default value here - we are just trying to find a valid PHP intepreter. I will 
change it to a warning.
Comment 7 Tomas Mysik 2008-08-22 11:30:12 UTC
Fixed, please verify.
http://hg.netbeans.org/main/rev/4f1a1a192f82
Comment 8 Quality Engineering 2008-08-22 17:20:46 UTC
Integrated into 'main-golden', available in build *200808221401* on http://bits.netbeans.org/dev/nightly/
Changeset: http://hg.netbeans.org/main/rev/4f1a1a192f82
User: Tomas Mysik <tmysik@netbeans.org>
Log: #144680: "OK" button is not activated on PHP option panel
Comment 9 Masaki Katakai 2008-08-23 11:48:15 UTC
It's great! Thank you for quick fixing. I verified that the issue does not happen on 200808230201.
Comment 10 Mikhail Matveev 2008-10-09 12:34:17 UTC
I'm reopening the issue because the warning is hard to notice. I would change its text color to red and add "Warning: "
at the beginning. I expect it's easy to fix.
Comment 11 Tomas Mysik 2008-10-09 13:02:38 UTC
> I'm reopening the issue because the warning is hard to notice. I would change its text color to red and
> add "Warning: " at the beginning. I expect it's easy to fix.

Closing because only errors have red color (or is there any "red" warning in the IDE?). The warning has correct color 
for warnings [errorLabel.setForeground(UIManager.getColor("nb.warningForeground"))] so if you are not satisfied with 
the current value, feel free to file a new issue against proper module (sorry, no idea which one it is).
Comment 12 Mikhail Matveev 2008-12-23 19:32:00 UTC
Well, since this is a general agreement, I have no more objections.