This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 100408 - Export org.netbeans.modules.db.util as a public package
Summary: Export org.netbeans.modules.db.util as a public package
Status: RESOLVED WONTFIX
Alias: None
Product: db
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: PC All
: P2 blocker (vote)
Assignee: John Baker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-10 02:23 UTC by John Baker
Modified: 2007-04-12 20:42 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Baker 2007-04-10 02:23:08 UTC
To support project migration feature in visualweb, I need to access
DriverListUtil which resides in package, org.netbeans.modules.db.util

This package is private.

If there's no reason for leaving it a private, I would like to change
it's accessibility to public

For visualweb, I need to load driver jar files then identify the driver
classname and driver name in order to add the driver to DatabaseExplorer.
DriverListUtil helps with providing this driver information.
Comment 1 Andrei Badea 2007-04-12 13:37:46 UTC
It seems you need this for the import of Creator userdirs, right? If that's the
case, I would not make the package public. It would be needed just for 6.0, but
it is not possible to unpublish it once it is public.

So what do you need this for?
Comment 2 John Baker 2007-04-12 18:38:08 UTC
yes, this is needed for import of Creator userdirs .

a workaround is to copy of DriverListUtil to visualweb/dataconnectivity

But, I don't see a problem with making this package public.
DriverListUtil would be better off in a public package 

Comment 3 John Baker 2007-04-12 18:55:23 UTC
nevermind, it's better to copy DriverListUtil to Visualweb just for 6.0
since it can just be removed in future releases

closing this 
Comment 4 Andrei Badea 2007-04-12 20:42:40 UTC
The problem with making this package public it that it was never intended to be
public. It contains implementation classes which were introduced as needed and
with no care about future evolution.

The DB Explorer API is going to be stable in 6.0, which means that you are not
allowed to make incompatible changes in any public package (well, at least not
without a very very good reason). So if you make o.n.m.db.util public you will
have a problem: since it was not written with evolution in mind, you will want
to change it, but you won't be allowed to. There is a really high price in
making classes public, and if you do, you must be prepared to pay that price.

As you said, if you need this for a single release it's better to copy it. And
if you realize that you actually need it in future releases too, you can reopen
this issue. A class providing the equivalent of the current DLU could be
introduced in a public package, or in the friend API provided by db/dbapi.