This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 105297 - Low performance of findDatasourceJndiName and findDatasourceJndiNameForEjb
Summary: Low performance of findDatasourceJndiName and findDatasourceJndiNameForEjb
Status: RESOLVED INVALID
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Infrastructure (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Sherold Dev
URL:
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2007-05-31 17:39 UTC by Sherold Dev
Modified: 2007-08-01 18:11 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sherold Dev 2007-05-31 17:39:22 UTC
When the current API is used for listing data sources in larger projects, the
performance might be really pure. The problem is that the

DatasourceConfiguration.findDatasourceJndiName(String referenceName)
DatasourceConfiguration.findDatasourceJndiNameForEjb(String ejbName, String
referenceName)

methods are called for each reference name and thus the server plugin has to
parse its server-specific descriptors multiple times. If a list of references
would be passed to the plugin, the plugin would need to parse the date only once.
Comment 1 Sherold Dev 2007-06-18 16:27:52 UTC
I was looking at how to make group versions of those two methods, but it turned out that the change won't be trivial and
the API would become quite complicated.

We would have to introduce new interfaces which would represent mappings between

1) <reference name, jndi name>
2) <ejb name, reference name>
3) <reference name, ejb name, reference name>

Since the change is not trivial and we don't have any proof of a real performance issue we should get some performance
data before doing any premature optimization.

TM -> 6.0
Comment 2 Petr Jiricka 2007-06-19 08:27:52 UTC
So is this really a defect? IMO this should be an enhancement by default, and we will change it to defect only if a real
performance problem is discovered.
Comment 3 Sherold Dev 2007-06-19 09:27:22 UTC
I don't think it is an enhancement, there is either a performance problem or the issue is invalid. We should definitely
make the measurements before closing the issue.
Comment 4 Radim Roska 2007-08-01 17:42:24 UTC
I have generated 1.4 EE ear project with 100 session beans. These beans have defined various data sources. When i tried
Use Database action from  Enterprise Resources menu... i didn't find any performance issue.
Comment 5 Sherold Dev 2007-08-01 18:11:55 UTC
Closing this issue as INVALID since we have no evidence of a significant performance problem. It is also quite unlikely
that someone will have more than just a few resource references defined in one module.