This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 107179 - [ProfilingPoints] Alt-F8 insertion can't be canceled
Summary: [ProfilingPoints] Alt-F8 insertion can't be canceled
Status: VERIFIED WONTFIX
Alias: None
Product: profiler
Classification: Unclassified
Component: Base (show other bugs)
Version: 6.x
Hardware: All All
: P4 blocker (vote)
Assignee: issues@profiler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-19 12:46 UTC by Alexander Kouznetsov
Modified: 2007-07-04 17:09 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kouznetsov 2007-06-19 12:46:57 UTC
Product Version: NetBeans IDE Dev (Build 200706180000) 
Java: 1.6.0; Java HotSpot(TM) Client VM 1.6.0-b105 
System: Windows XP version 5.1 running on x86; Cp1251; ru_RU (nb)
org.netbeans.modules.profiler/1 [1.1.1 070615]

When new profiling point is being inserted with Insert Profiling Point dialog, user can cancel the insertion it any
moment by hitting Cancel. When new PP is being inserted using Alt-F8, canceling of the dialog doesn't lead to canceling
of an insertion. User needs to delete the PP manually.
Comment 1 Jiri Sedlacek 2007-06-19 13:22:42 UTC
I know about this problem but because of exactly the same problems as already described in Issue 107181 it's not clear 
how to fix it. Please note that whereas for Insert Profiling Point action the user interacts with a regular dialog, for 
Alt-F8 there's no real dialog, just a popup window which disappears after releasing the Alt key, so ESC is not expected 
to work by default. There's another way how to cancel inserting the PP, just cycle through all the PPs and the last 
command is Cancel.

Lowering priority because Cancel is avaiable in the UI and deleting accidentaly created PP is very simple.
Comment 2 Alexander Kouznetsov 2007-06-19 13:43:56 UTC
Well, sorry for misunderstanding. Original description treats canceling problem only for Customize Profiling Point
dialog which is opened after Profiling Point is created using Alt-F8. I believe that in this situation the dialog needs
"Add Profiling Point" title and hitting Cancel button should lead to removal of newly added PP.

BTW, ESC perfectly works for Alt-F8 cycle on my WinXP laptop.
Comment 3 Jiri Sedlacek 2007-06-25 14:40:04 UTC
OK, I see.

In fact there are two possibilities how inserting the PP using Alt-F8 could be implemented:

 1/ By opening "customizer" and creating the PP after closing this customizer using OK button
 2/ By creating new PP with default (& "smart") values and immediately opening its customizer for the user to 
see/modify these values.

Both approaches have their pros and cons, during implementation I've decided to use 2/. For this approach it's 
perfectly OK to call the dialog "Customize Profiling Point" and just do no changes to PP when the dialog is canceled. 
At this time the PP is already created, you can see it in editor and Profiling Points window.

Again, for canceling creation of new PP using the keyboard shortcut the last toggle option "Cancel" should be used.

I've discussed this internaly with rest of the developers and we've decided to keep this approach for 6.0 and 
eventually change it in following release if we obtain negative feedback from users. If you think that this must be 
certainly changed, please file new RFE.
Comment 4 Alexander Kouznetsov 2007-07-04 17:09:21 UTC
ok