This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 113553 - Suppress confusing sentence in Attach Wizard
Summary: Suppress confusing sentence in Attach Wizard
Status: RESOLVED WORKSFORME
Alias: None
Product: profiler
Classification: Unclassified
Component: Base (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: issues@profiler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-22 22:14 UTC by _ gsporar
Modified: 2008-10-08 12:28 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description _ gsporar 2007-08-22 22:14:19 UTC
Using the daily build from 2007-08-21.

1. Profile > Attach Profiler
2. Click the define link to bring up the attach wizard
3. For Target Type: select Application 
4. For attach method choose Local and for attach invocation choose Dynamic (JDK 1.6)
5. Click Next

The Review Attach Settings is displayed and the text at the bottom says:

If these settings are correct, click the Finish button to close Attach Wizard and start profiling.  If you haven't
integrated the Java Application for profiling yet, click the Next button to continue with Java Application Integration.

This sentence: "If you haven't integrated the Java Application for profiling yet, click the Next button to continue with
Java Application Integration" does not really make sense in this context.  There is no "integration" needed in this
case, since I selected "Dynamic (JDK 1.6)."  The whole idea behind doing dynamic attach with JDK 6 is that *no*
integration is needed.  :-)

Can we suppress that sentence?  Maybe even disable the Next button so that the user is clear on what they need to do:
click Finish in order to go back to the Attach Profiler dialog.
Comment 1 Jiri Sedlacek 2007-08-23 15:30:55 UTC
I don't agree - even for dynamic attach using JDK6 the integration is required - it means setting the profiled app up 
to run on JDK6. Many users don't know how to do it for Tomcat or GlassFish or other servers. In fact also the most 
general hint suggesting just changing the $JAVA_HOME env. variable can be useful for many apps & users.

For the servers there is also an useful bonus - starting the server automatically after modifying it to run on JDK6 so 
it's ready for the profiler to attach dynamically. I'm about to close this issue as INVALID, but will wait for your 
comments.
Comment 2 William Leonard 2007-08-23 16:07:40 UTC
Gregg filed this bug on my behalf, as I was utterly confused by the dialog and specifically the sentence Gregg points
out below: "If you haven't integrated the Java Application for profiling yet, click the Next button to continue with
Java Application Integration". Could it be made more clear to describe your answer below? And I'm not sure how
continuing with the wizard helps me solve this problem. Basically the application just needs to be running under Java
6.0. I would expect the dialog to say something like:

"If these settings are correct, make sure the application to which you want to attach is running under Java 6 and close
the Attach Wizard to start profiling." I don't see the need for the Next button.

Hope that helps,
Brian
Comment 3 Jiri Sedlacek 2007-08-23 19:43:49 UTC
Try to play with the Attach Wizard and select various target types - Java apps, applets, servers. You'll see that the 
UI of the wizard is consistent for each target type, only the instructions vary for each target type/version. I don't 
think that the bottom hints and especially the wizard workflow should change significantly based on what's selected for 
profiling - at least it's not possible with current implementation.

Whereas for setting JDK for j2se app is in most cases quite straightforward, for various web/app servers it could be 
really difficult for unexperienced user without this extra wizard step. That's why I want to keep it for now. And even 
for the j2se app you'll get some useful hints about space in path and reducing profiling overhead.

On the other side, it's apparent that there are some usability problems with this wizard. We are definitely open for 
any new ideas and would appreciate if you could file a RFE for new attach wizard and suggest something better (FYI 
current attach wizard mostly reflects what other profilers offered at that time). But it's too late for this release to 
make such changes - we can reimplement it after 6.0.

For now I would be happy if anyone from docs/evangelism team could suggest better hint so we can improve it for 6.0.
Comment 4 Jiri Sedlacek 2007-08-23 19:53:15 UTC
FYI, the hint should:

 1/ be the same for all target types
 2/ should make clear that at this point all data required for attach setup are entered and user can finish the wizard, 
all other steps are related just to the integration between profiler & profiled app
 3/ should somehow describe that the real integration (== config scripts changes) needs to be performed only once
Comment 5 Jiri Sedlacek 2007-08-23 20:05:26 UTC
Filed an issue to update instructions for dynamic attach: Issue 113655. They may illustrate why instructions in extra 
step could be useful also for j2se app.
Comment 6 J Bachorik 2007-09-21 15:59:04 UTC
gregg, could you, please, take a look at the update attach instructions for dynamic attach? it's clear that it's
necessary to give the user some hints about the prerequisities for dynamic attach but also it's true that the word
"integration" doesn't sound very nice when using the dynamic attach. 
what about using "To see dynamic attach prerequisities in detail press Next" or something similar for dynamic attach?
Comment 7 _ gsporar 2007-10-02 10:12:55 UTC
>"To see dynamic attach prerequisities in detail press Next"

That would be an improvement.  :-)

I'd like to go back to the comment from jis: "... it's apparent that there are some usability problems with this wizard.
We are definitely open for any new ideas and would appreciate if you could file a RFE"

I have opened: http://www.netbeans.org/issues/show_bug.cgi?id=117412
Comment 8 Jiri Sedlacek 2007-10-02 10:24:32 UTC
>"To see dynamic attach prerequisities in detail press Next"

 -- I still think that this isn't correct for automatic integration with some servers, in this step you'll get more than
just the list of prerequisites.
Comment 9 _ gsporar 2007-10-02 10:38:28 UTC
>this isn't correct for automatic integration with some servers

Hmmm... okay.  Could we just use the new sentence in situations where the user has chosen "Application" ?
Comment 10 Tomas Hurka 2007-11-07 10:35:52 UTC
Changing target milestone to dev, since NetBeans 6.0 is in high resistance mode.
Comment 11 mariadavydova 2008-09-01 15:46:19 UTC
Any update on this issue?
Comment 12 mariadavydova 2008-10-08 12:28:37 UTC
Remove INCOMPLETE. 
Resolve as WORKSFORME due to no any update.